fix(amazonq): fix for /test authentication check #5355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| import software.aws.toolkits.jetbrains.services.amazonqCodeTest.storage.ChatSessionStorage | ||
| import software.aws.toolkits.jetbrains.services.cwc.messages.ChatMessageType | ||
| import software.aws.toolkits.jetbrains.services.cwc.messages.FollowUp | ||
| import software.aws.toolkits.resources.message |
Check warning
Code scanning / QDJVMC
Usage of redundant or deprecated syntax or deprecated symbols Warning
|
|
||
| suspend fun sendChatInputEnabledMessage(isEnabled: Boolean) { | ||
| if (isInvalidSession()) return | ||
| messagePublisher.publish(ChatInputEnabledMessage(activeCodeTestTabId as String, enabled = isEnabled)) |
Check warning
Code scanning / QDJVMC
Usage of redundant or deprecated syntax or deprecated symbols Warning
| tabId = tabId, | ||
| messageId = messageId ?: UUID.randomUUID().toString(), | ||
| messageType = ChatMessageType.Answer, | ||
| message = message("amazonqFeatureDev.follow_instructions_for_authentication"), |
Check warning
Code scanning / QDJVMC
Usage of redundant or deprecated syntax or deprecated symbols Warning
laileni-aws
reviewed
Feb 11, 2025
...oftware/aws/toolkits/jetbrains/services/amazonqCodeTest/controller/CodeTestChatController.kt
Show resolved
Hide resolved
samgst-amazon
pushed a commit
that referenced
this pull request
Feb 12, 2025
* Correcting auth checks for /test workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Q Test Generation is seeing quite a few job failures due to unauthorized API calls to service. Q Test workflow's existing checks are for older version of Q. Updated the auth checks to re-authenticate in chat like other features.
Testing: tested with credential state set to Re-Auth to check the re-prompt to browser re-auth.
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.