Skip to content

fix(amazonq): also terminate lsp process on other initialization failures #5371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2025
Merged

fix(amazonq): also terminate lsp process on other initialization failures #5371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...s-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLspService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,11 +214,13 @@
} catch (_: TimeoutCancellationException) {
LOG.warn { "LSP initialization timed out" }
null
} catch (e: Exception) {
LOG.warn(e) { "LSP initialization failed" }
null

Check warning on line 219 in plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLspService.kt

View check run for this annotation

Codecov / codecov/patch

plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLspService.kt#L217-L219 

Added lines #L217 - L219 were not covered by tests
}

// then if this succeeds then we can allow the client to send requests
if (initializeResult == null) {
LOG.warn { "LSP initialization failed" }
launcherHandler.destroyProcess()
}
languageServer.initialized(InitializedParams())
Expand Down
Loading