Skip to content

log(amazonq): update log string when workspace process is not spinned up #5375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 18, 2025
Merged

log(amazonq): update log string when workspace process is not spinned up #5375

merged 10 commits into from
Feb 18, 2025

Conversation

@Will-ShaoHua
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Will-ShaoHua Will-ShaoHua requested a review from a team as a code owner February 13, 2025 20:53
@Will-ShaoHua Will-ShaoHua requested a review from a team as a code owner February 14, 2025 18:12
leigaol
leigaol reviewed Feb 14, 2025
View reviewed changes
...ity/src/software/aws/toolkits/jetbrains/services/amazonq/project/ProjectContextController.kt Outdated
fun getProjectContextIndexComplete() = projectContextProvider.isIndexComplete.get()

suspend fun queryChat(prompt: String, timeout: Long?): List<RelevantDocument> {
if (!getProjectContextIndexComplete()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is actually allowed

@Will-ShaoHua Will-ShaoHua changed the title refactor(amazonq): add safe checks of workspace process status before making calls refactor(amazonq): update log string when workspace process is not spinned up Feb 17, 2025
@Will-ShaoHua
Copy link
Contributor Author

check was already added by #5373 https://github.com/aws/aws-toolkit-jetbrains/pull/5373/files#diff-3167628e4191cb5a26415ef703461b625e5b7c7e00cee7e998157ea47df9c21eR316-R319

@Will-ShaoHua Will-ShaoHua changed the title refactor(amazonq): update log string when workspace process is not spinned up log(amazonq): update log string when workspace process is not spinned up Feb 17, 2025
@Will-ShaoHua
Copy link
Contributor Author

/retryBuilds

@rli rli merged commit f5460c7 into aws:main Feb 18, 2025
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rli rli rli approved these changes

+1 more reviewer

@leigaol leigaol leigaol approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Will-ShaoHua @rli @leigaol