Skip to content

Conversation

@rli
Copy link
Contributor

@rli rli commented Feb 18, 2025

This adds the command to restart the Q LSP and exposes a prelimiary invocation interface for calling LSP commands outside of the q language service interface

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

This adds the command to restart the Q LSP and exposes a prelimiary invocation interface
for calling LSP commands outside of the q language service interface
@rli rli requested a review from a team as a code owner February 18, 2025 02:06
@github-actions
Copy link

github-actions bot commented Feb 18, 2025

Qodana Community for JVM

2 new problems were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 2

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

override fun dispose() {
}

suspend fun restart() = mutex.withLock {

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Function "restart" is never used
private val LOG = getLogger<AmazonQLspService>()
fun getInstance(project: Project) = project.service<AmazonQLspService>()

fun executeIfRunning(project: Project, runnable: (AmazonQLanguageServer) -> Unit) =

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Function "executeIfRunning" is never used
@rli rli merged commit d927594 into feature/q-lsp Feb 18, 2025
14 of 18 checks passed
@rli rli deleted the rli/lsp-lifecycle branch February 18, 2025 19:48
leigaol pushed a commit to leigaol/aws-toolkit-jetbrains that referenced this pull request Mar 20, 2025
This adds the command to restart the Q LSP and exposes a preliminary invocation interface for calling LSP commands outside of the project service
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants