feat(amazonq): Added LSP Manifest manager related changes #5387

LokeshDogga13 · 2025-02-18T21:30:10Z

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Description

Added Manifest fetcher to manage LSP manifest.

Checklist

My code follows the code style of this project
I have added tests to cover my changes
A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

...munity/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/artifacts/ManifestFetcher.kt

...ity/src/software/aws/toolkits/jetbrains/services/amazonq/project/manifest/ManifestManager.kt

rli · 2025-02-18T21:38:36Z

...munity/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/artifacts/ManifestFetcher.kt

+import java.nio.file.Paths
+
+
+class ManifestFetcher {


can we replace the existing implementation with this?

...munity/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/artifacts/ManifestFetcher.kt

github-actions · 2025-02-18T21:59:56Z

Qodana Community for JVM

2 new problems were found

Inspection name	Severity	Problems
`Unused symbol`	🔶 Warning	2

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Or via our issue tracker: https://jb.gg/qodana-issue
Or share your feedback: https://jb.gg/qodana-discussions

...munity/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/artifacts/ManifestFetcher.kt

…ogga/initialChanges

...ins-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/artifacts/LspUtils.kt

...ty/tst/software/aws/toolkits/jetbrains/services/amazonq/lsp/artifacts/ManifestFetcherTest.kt

...munity/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/artifacts/ManifestFetcher.kt

...ins-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/artifacts/LspUtils.kt

...munity/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/artifacts/ArtifactManager.kt

+    }
+
+    // Secondary constructor with no parameters
+    constructor() : this(ManifestFetcher(), ArtifactHelper(), null)


...munity/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/artifacts/ArtifactManager.kt

+        private val logger = getLogger<ArtifactManager>()
+    }
+
+    fun fetchArtifact() {


...community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/artifacts/LspException.kt

...mmunity/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/artifacts/ArtifactHelper.kt

...munity/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/artifacts/ArtifactManager.kt

rli · 2025-02-26T18:59:59Z

...ins-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/artifacts/LspUtils.kt

+
+fun getCurrentArchitecture() = when {
+    CpuArch.CURRENT == CpuArch.X86_64 -> "x64"
+    else -> "arm64"


should also handle unknown case

…verride via config (#5449) download implemented in #5387 override UI implemented in #5429 Additionally, use zipfs for extracting zip files to respect original posix attributes on systems where that is relevant

* Added Manifest Fetcher * Addressing code review comments * Added unit test cases * Fixing lint issues * Addressing code review comments * Addressing code review comments * Fixing lint issues * Addressing code review comments * Fixing detektMain lint issues * Added unit test cases * Updating code according to spec. * detekt * Fixing typo * Artifact changes * Fixing validation function * Addressing code review comments * Fixing Detekt

…verride via config (aws#5449) download implemented in aws#5387 override UI implemented in aws#5429 Additionally, use zipfs for extracting zip files to respect original posix attributes on systems where that is relevant

Added Manifest Fetcher

c4aa8cb

LokeshDogga13 requested a review from a team as a code owner February 18, 2025 21:30

LokeshDogga13 changed the title ~~LSP Manifest changes~~ Added LSP Manifest manager related changes Feb 18, 2025

LokeshDogga13 changed the title ~~Added LSP Manifest manager related changes~~ feat(amazonq): Added LSP Manifest manager related changes Feb 18, 2025

LokeshDogga13 closed this Feb 18, 2025

LokeshDogga13 reopened this Feb 18, 2025

rli reviewed Feb 18, 2025

View reviewed changes

github-advanced-security bot found potential problems Feb 18, 2025

View reviewed changes

...munity/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/artifacts/ManifestFetcher.kt Fixed Show fixed Hide fixed

...munity/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/artifacts/ManifestFetcher.kt Fixed Show fixed Hide fixed

LokeshDogga13 added 2 commits February 18, 2025 14:30

Addressing code review comments

d1ca7d1

Added unit test cases

600f91a

LokeshDogga13 requested a review from a team as a code owner February 18, 2025 23:13

LokeshDogga13 added 7 commits February 18, 2025 15:24

Fixing lint issues

cad10ef

Merge branch 'feature/q-lsp' into lodogga/initialChanges

2607eec

Addressing code review comments

b0e9648

Addressing code review comments

973b710

Merge branch 'feature/q-lsp' into lodogga/initialChanges

2641472

Fixing lint issues

fef3b06

Merge remote-tracking branch 'origin/lodogga/initialChanges' into lod…

539cb7e

…ogga/initialChanges

rli reviewed Feb 19, 2025

View reviewed changes

...ins-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/artifacts/LspUtils.kt Outdated Show resolved Hide resolved

...ins-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/artifacts/LspUtils.kt Outdated Show resolved Hide resolved

rli reviewed Feb 19, 2025

View reviewed changes

LokeshDogga13 added 7 commits February 19, 2025 15:22

Addressing code review comments

563ca08

Fixing detektMain lint issues

8f44478

Added unit test cases

30f8dc6

Merge branch 'feature/q-lsp' into lodogga/initialChanges

eef3e59

Updating code according to spec.

bc25fb9

detekt

7ac76b0

Merge branch 'feature/q-lsp' into lodogga/initialChanges

a28dca7

github-advanced-security bot found potential problems Feb 24, 2025

View reviewed changes

...ins-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/artifacts/LspUtils.kt Fixed Show fixed Hide fixed

...ins-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/artifacts/LspUtils.kt Fixed Show fixed Hide fixed

Fixing typo

20e7451

Artifact changes

a970509

github-advanced-security bot found potential problems Feb 25, 2025

View reviewed changes

LokeshDogga13 added 2 commits February 25, 2025 16:04

Fixing validation function

44f5c7b

Merge branch 'feature/q-lsp' into lodogga/initialChanges

60c4b1c

rli reviewed Feb 26, 2025

View reviewed changes

LokeshDogga13 added 3 commits February 26, 2025 12:17

Addressing code review comments

65f6f68

Merge branch 'feature/q-lsp' into lodogga/initialChanges

224289d

Fixing Detekt

3e1bc1e

rli approved these changes Feb 26, 2025

View reviewed changes

LokeshDogga13 merged commit 179aea2 into feature/q-lsp Feb 26, 2025
15 of 18 checks passed

LokeshDogga13 deleted the lodogga/initialChanges branch February 26, 2025 21:45

rli mentioned this pull request Mar 6, 2025

feat(amazonq): launch lsp from resolved artifacts and allow user to override via config #5449

Merged

		import java.nio.file.Paths


		class ManifestFetcher {

feat(amazonq): Added LSP Manifest manager related changes #5387

feat(amazonq): Added LSP Manifest manager related changes #5387

Uh oh!

Conversation

LokeshDogga13 commented Feb 18, 2025

Types of changes

Description

Checklist

License

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rli Feb 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Qodana Community for JVM

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check warning

Check warning

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rli Feb 26, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Feb 18, 2025 •

edited

Loading