fix(amazonq): skip tests locally #5401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhasani23
commented
Feb 21, 2025
| FormItemOption( | ||
| label = message("codemodernizer.chat.message.skip_tests_form.skip"), | ||
| value = message("codemodernizer.chat.message.skip_tests_form.skip"), | ||
| ) |
There was a problem hiding this comment.
Just switch the order of these 2 options so that "skip tests" is the default
dhasani23
commented
Feb 21, 2025
| } else { | ||
| } else if (CodeModernizerSessionState.getInstance(context.project).currentJobId != null) { | ||
| val downloadResult = artifactHandler.downloadArtifact( | ||
| CodeModernizerSessionState.getInstance(context.project).currentJobId as JobId, |
There was a problem hiding this comment.
Before attempting download, make sure that a job ID exists (job may not have started otherwise, so nothing to download)
...ity/src/software/aws/toolkits/jetbrains/services/codemodernizer/ideMaven/MavenRunnerUtils.kt
Outdated
Show resolved
Hide resolved
ntarakad-aws
approved these changes
Feb 21, 2025
dhasani23
commented
Feb 21, 2025
| sourceFolder: File, | ||
| destinationDir: File, | ||
| buildlogBuilder: StringBuilder, | ||
| logBuilder: StringBuilder, |
There was a problem hiding this comment.
Got a detekt error elsewhere because a line was too long, so just shortened this name everywhere in this file
samgst-amazon
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Pass in the
-DskipTestsflag when users choose to skip tests, so that they are actually skipped locally.Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.