fix(amazonq): lsp token/update emits for init, logins, and token refresh #5477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana Community for JVM16 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
Contributor
|
Overall looks good! Can you double check if this code path triggers bearer token refresh? |
leigaol
approved these changes
Mar 14, 2025
manodnyab
approved these changes
Mar 14, 2025
Comment on lines
+65
to
+69
| val qConnection = ToolkitConnectionManager.getInstance(project) | ||
| .activeConnectionForFeature(QConnection.getInstance()) | ||
| ?: return | ||
| if (newConnection?.id != qConnection.id) return | ||
|
|
Contributor
There was a problem hiding this comment.
non-blocking, but are we sure these lines are not duplicated? I think they already exist somewhere in CW
manodnyab
reviewed
Mar 14, 2025
Comment on lines
+82
to
+85
| (connection.getConnectionSettings() as? TokenConnectionSettings) | ||
| ?.tokenProvider | ||
| ?.delegate | ||
| ?.let { it as? BearerTokenProvider } |
Contributor
There was a problem hiding this comment.
can we move this to a util
manodnyab
reviewed
Mar 14, 2025
| ?.let { it as? BearerTokenProvider } | ||
| ?.currentToken() | ||
| ?.accessToken | ||
| ?.let { token -> updateTokenCredentials(token, true) } |
Contributor
There was a problem hiding this comment.
can you please add the var name before the boolean?
leigaol
pushed a commit
to leigaol/aws-toolkit-jetbrains
that referenced
this pull request
Mar 17, 2025
…esh (aws#5477) * emit on login * reorder * tests
leigaol
pushed a commit
to leigaol/aws-toolkit-jetbrains
that referenced
this pull request
Mar 20, 2025
…esh (aws#5477) * emit on login * reorder * tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a listener and changed some of the init logic to better handle auth events for emitting the token to the LSP
Types of changes
Description
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.