-
Notifications
You must be signed in to change notification settings - Fork 274
test(qdoc): Add ui tests for qdoc create readme flow #5479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/runUiTests |
| assertTrue(result.contains("Test Successful")) | ||
| assertFalse(result.contains("Error: Test Failed")) | ||
| if (result.contains("Error: Test Failed")) { | ||
| println("result: $result") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting why logger is not configured for those tests like it is configured for ui-tests/tst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the console.log statements in the puppeteer scripts doesn't log and is diverted to the result variable, just adding a precautionary logging in case the test case failed, the test scripts have a lot more detailed logging as the test progresses
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please try looking at the detailed logs from the plugin to see if you can see these errors, then we can remove the print statements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I looked at all logs for a failure and success test case and the puppeteer script logs were not present in any file, so keeping these in to ensure we can debug test failures. Could be something wrong with the driver if it's supposed to be logging all the logs from the puppeteer script execution?
...-243+/software/aws/toolkits/jetbrains/uitests/docTests/createReadmeTests/CreateReadmeTest.kt
Show resolved
Hide resolved
...-243+/software/aws/toolkits/jetbrains/uitests/docTests/createReadmeTests/CreateReadmeTest.kt
Show resolved
Hide resolved
| val testCase = TestCase( | ||
| IdeProductProvider.IC, | ||
| LocalProjectInfo( | ||
| Paths.get("tstData", "qdoc", "createFlow") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the difference other than the readme file between the 2 projects? Is there a way we can reuse the existing project?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a test case (in progress) that tests if we are able to generate a readme in a multi-root workspace so reusing doesn't help, we would still need atleast two different dummy repos for testing
...-243+/software/aws/toolkits/jetbrains/uitests/docTests/createReadmeTests/CreateReadmeTest.kt
Show resolved
Hide resolved
| assertTrue(result.contains("Test Successful")) | ||
| assertFalse(result.contains("Error: Test Failed")) | ||
| if (result.contains("Error: Test Failed")) { | ||
| println("result: $result") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please try looking at the detailed logs from the plugin to see if you can see these errors, then we can remove the print statements
ef3c4ef to
a85591e
Compare
|
/runUiTests |
Types of changes
Description
Followups from #5435:
findAndClickButtonto a common Utils.kt file in the tests directoryAdd UI tests to validate the
Create a READMEflowCreated a sample repository from scratch,
There are 5 test cases which validate the following
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.