fix(amazonq): fix didChangeDependencyPathsParams with absolute pathing #5492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samgst-amazon
commented
Mar 21, 2025
| dependencies.add(pkg.name) | ||
| PythonSdkUtil.getSitePackagesDirectory(sdk)?.let { sitePackagesDir -> | ||
| val packageManager = PythonPackageManager.forSdk(module.project, sdk) | ||
| packageManager.installedPackages.forEach { pkg -> |
Contributor
Author
There was a problem hiding this comment.
I'm still not certain this is the proper way to get Python packages -- need to revisit with better test setup
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
rli
reviewed
Mar 21, 2025
| library.getUrls(OrderRootType.CLASSES).forEach { url -> | ||
| dependencies.add(VfsUtil.urlToPath(url)) | ||
| library.getFiles(OrderRootType.CLASSES).forEach { file -> | ||
| dependencies.add(file.path.removeSuffix("!/")) |
Contributor
There was a problem hiding this comment.
where does this suffix come from?
Contributor
Author
There was a problem hiding this comment.
signifies jar as root archive path, was told this was not needed for flare purposes
| dependencies.add(pkg.name) | ||
| PythonSdkUtil.getSitePackagesDirectory(sdk)?.let { sitePackagesDir -> | ||
| val packageManager = PythonPackageManager.forSdk(module.project, sdk) | ||
| packageManager.installedPackages.forEach { pkg -> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
module name now returns absolute path of module
files/dirs replaced with paths for dependency path
Types of changes
Description
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.