style: ban org.junit.Assert and org.junit.jupiter.api.Assertions

[rli]

Fluent assertions through AssertJ result in more useful test output

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

[rli]

/runUiTests

[github-actions]

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions

[rli]

Prior:

com.intellij.ide.starter.driver.engine.DriverWithContextError: ?[35m
----Driver Error----
?[0m?[34mexpected: <true> but was: <false>
?[0mAssertionFailedError
	at software.aws.toolkits.jetbrains.uitests.docTests.createReadmeTests.CreateReadmeTest.Make_changes_button_brings_you_to_UPDATE_with_specific_changes_flow$lambda$12(CreateReadmeTest.kt:161)

with change:

com.intellij.ide.starter.driver.engine.DriverWithContextError: ?[35m
----Driver Error----
?[0m?[34m
Expecting actual:
  "Error: Test Failed
TypeError: Failed to fetch browser webSocket URL from http://localhost:9222/json/version: fetch failed
    at node:internal/deps/undici/undici:13502:13
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async getWSEndpoint (/codebuild/output/src4131624190/src/github.com/aws/aws-toolkit-jetbrains/ui-tests-starter/node_modules/puppeteer-core/lib/cjs/puppeteer/common/BrowserConnector.js:103:24)
    at async getConnectionTransport (/codebuild/output/src4131624190/src/github.com/aws/aws-toolkit-jetbrains/ui-tests-starter/node_modules/puppeteer-core/lib/cjs/puppeteer/common/BrowserConnector.js:90:31)
    at async _connectToBrowser (/codebuild/output/src4131624190/src/github.com/aws/aws-toolkit-jetbrains/ui-tests-starter/node_modules/puppeteer-core/lib/cjs/puppeteer/common/BrowserConnector.js:60:50)
    at async testNavigation (/codebuild/output/src4131624190/src/github.com/aws/aws-toolkit-jetbrains/ui-tests-starter/src/test/tstData/temp-script.js:4:21) {
  [cause]: Error: connect ECONNREFUSED 127.0.0.1:9222
      at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1611:16) {
    errno: -111,
    code: 'ECONNREFUSED',
    syscall: 'connect',
    address: '127.0.0.1',
    port: 9222
  }
}
"
to contain:
  "Test Successful" 
?[0mAssertionError
	at software.aws.toolkits.jetbrains.uitests.docTests.createReadmeTests.CreateReadmeTest.Make_changes_button_brings_you_to_UPDATE_with_specific_changes_flow$lambda$12(CreateReadmeTest.kt:157)