Skip to content

feat(amazonq): Enable checkbox to accept or block code fix with references #5509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 31, 2025
Merged

feat(amazonq): Enable checkbox to accept or block code fix with references #5509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f1f9a4d
/review: passing referenceTrackerConfiguration to StartCodeFixJob
atonaamz Mar 24, 2025
19d55ac
Update changelog description
atonaamz Mar 27, 2025
0b42ee1
Merge branch 'main' into main
atonaamz Mar 27, 2025
5ede4cf
Merge branch 'main' into main
rli Mar 27, 2025
89f47e4
Update .changes/next-release/feature-21a9e26b-edbf-4ad3-a5f4-2662420d…
atonaamz Mar 27, 2025
5a788ea
Merge branch 'main' into main
atonaamz Mar 27, 2025
91d4902
Merge branch 'main' into main
atonaamz Mar 27, 2025
17baa46
Merge branch 'main' into main
atonaamz Mar 31, 2025
0ac4e6f
Merge branch 'main' into main
atonaamz Mar 31, 2025
40da3f7
Merge branch 'main' into main
atonaamz Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .changes/next-release/feature-21a9e26b-edbf-4ad3-a5f4-2662420d4f0d.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"type" : "bugfix",
"description" : "/review: Respect user option to allow code suggestions with references"
}
9 changes: 9 additions & 0 deletions .../software/aws/toolkits/jetbrains/services/codewhisperer/codescan/AmazonQCodeFixSession.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import software.amazon.awssdk.services.codewhispererruntime.model.GetCodeFixJobR
import software.amazon.awssdk.services.codewhispererruntime.model.GetCodeFixJobResponse
import software.amazon.awssdk.services.codewhispererruntime.model.Position
import software.amazon.awssdk.services.codewhispererruntime.model.Range
import software.amazon.awssdk.services.codewhispererruntime.model.RecommendationsWithReferencesPreference
import software.amazon.awssdk.services.codewhispererruntime.model.StartCodeFixJobRequest
import software.amazon.awssdk.services.codewhispererruntime.model.StartCodeFixJobResponse
import software.amazon.awssdk.services.codewhispererruntime.model.UploadContext
Expand All @@ -28,6 +29,7 @@ import software.aws.toolkits.jetbrains.services.codewhisperer.credentials.CodeWh
import software.aws.toolkits.jetbrains.services.codewhisperer.util.CodeWhispererConstants
import software.aws.toolkits.jetbrains.services.codewhisperer.util.CodeWhispererZipUploadManager
import software.aws.toolkits.jetbrains.services.codewhisperer.util.getTelemetryErrorMessage
import software.aws.toolkits.jetbrains.settings.CodeWhispererSettings
import software.aws.toolkits.resources.message
import java.io.File
import java.nio.file.Path
Expand Down Expand Up @@ -161,12 +163,19 @@ class AmazonQCodeFixSession(val project: Project) {
codeFixName: String? = null,
ruleId: String? = null,
): StartCodeFixJobResponse {
val includeCodeWithReference = if (CodeWhispererSettings.getInstance().isIncludeCodeWithReference()) {
RecommendationsWithReferencesPreference.ALLOW
} else {
RecommendationsWithReferencesPreference.BLOCK
}

val request = StartCodeFixJobRequest.builder()
.uploadId(uploadId)
.snippetRange(snippetRange)
.codeFixName(codeFixName)
.ruleId(ruleId)
.description(description)
.referenceTrackerConfiguration { it.recommendationsWithReferences(includeCodeWithReference) }
.build()

return try {
Expand Down
Loading