fix(amazonq): fix LspUtilsTest in 241 #5522
Conversation
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
|
/retryBuilds |
1 similar comment
|
/retryBuilds |
| val targetPath = zipfs.getPath("/").resolve(source.relativize(file).toString()) | ||
| Files.copy(file, targetPath) | ||
| val sourcePerms = Files.getPosixFilePermissions(file) | ||
| Files.setPosixFilePermissions(targetPath, sourcePerms) |
There was a problem hiding this comment.
linux 241 fixed but now this breaks the windows builds:
LSP Error [UNZIP_FAILED]: Failed to extract zip file: Attributes of type java.nio.file.attribute.PosixFileAttributes not supported
There was a problem hiding this comment.
odd this test should not be running on windows. but also it seems like 241 tests spontaneously fixed themselves?
There was a problem hiding this comment.
241 works here when the permission copying is split up like this in this PR, but from what I see in the feature branch commits 241 is still broken.
2 participants
extractZipFile respects posix was not correctly copying over file permissions in 2024.1 for some reason. Explicitly copying the permissions both in the test and in the util function fixes this issue.
Types of changes
Description
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.