Skip to content

Conversation

@samgst-amazon
Copy link
Contributor

Document renames should be signaled to a server sending a document close notification with the document’s old name followed by an open notification using the document’s new name. Major reason is that besides the name other attributes can change as well like the language that is associated with the document. In addition the new document could not be of interest for the server anymore.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

DidRename now calls didClose for the old Uri and didOpen for the new one. Ignores these calls for directory renames/ unsupported filetypes.

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@samgst-amazon samgst-amazon requested review from a team as code owners March 29, 2025 00:05
@samgst-amazon samgst-amazon changed the base branch from main to feature/q-lsp March 29, 2025 00:05
@github-actions
Copy link

github-actions bot commented Mar 29, 2025

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@samgst-amazon
Copy link
Contributor Author

/retryBuilds

@samgst-amazon samgst-amazon enabled auto-merge (squash) March 31, 2025 22:55
@samgst-amazon samgst-amazon disabled auto-merge April 1, 2025 18:19
@samgst-amazon samgst-amazon merged commit 3abcd1f into feature/q-lsp Apr 1, 2025
15 of 18 checks passed
@samgst-amazon samgst-amazon deleted the samgst/q-lsp-did-rename-spec-update branch April 1, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants