-
Notifications
You must be signed in to change notification settings - Fork 274
fix(amazonq): cache the listAvailableProfiles result #5544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
8223470
Merge staging into feature/q-region-expansion
aws-toolkit-automation 9105243
call if
evanliu048 ae016bd
add cache
evanliu048 c1474fe
linter
evanliu048 e2967bf
Merge staging into feature/q-region-expansion
aws-toolkit-automation cbb548d
Merge branch 'main' into regionExpansion_fixlaunch
evanliu048 0ec0d1f
Merge staging into feature/q-region-expansion
aws-toolkit-automation 07e63ca
delete ut
evanliu048 de7a0f0
test
evanliu048 1a4a5db
Merge branch 'feature/q-region-expansion' into regionExpansion_fixlaunch
evanliu048 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 39 additions & 0 deletions
39
...mmunity/src/software/aws/toolkits/jetbrains/services/amazonq/profile/QProfileResources.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| // Copyright 2025 Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| package software.aws.toolkits.jetbrains.services.amazonq.profile | ||
|
|
||
| import software.amazon.awssdk.services.codewhispererruntime.CodeWhispererRuntimeClient | ||
| import software.aws.toolkits.core.ClientConnectionSettings | ||
| import software.aws.toolkits.jetbrains.core.AwsClientManager | ||
| import software.aws.toolkits.jetbrains.core.Resource | ||
| import software.aws.toolkits.jetbrains.core.region.AwsRegionProvider | ||
| import java.time.Duration | ||
|
|
||
| /** | ||
| * Save Amazon Q Profile Resource Cache | ||
| */ | ||
| object QProfileResources { | ||
| /** | ||
| * save available Q Profile list as cache with default duration 60 s。 | ||
| */ | ||
| val LIST_REGION_PROFILES = object : Resource.Cached<List<QRegionProfile>>() { | ||
| override val id: String = "amazonq.allProfiles" | ||
|
|
||
| override fun fetch(connectionSettings: ClientConnectionSettings<*>): List<QRegionProfile> { | ||
| val mappedProfiles = QEndpoints.listRegionEndpoints().flatMap { (regionKey, _) -> | ||
| val awsRegion = AwsRegionProvider.getInstance()[regionKey] ?: return@flatMap emptyList() | ||
| val client = AwsClientManager | ||
| .getInstance() | ||
| .getClient(CodeWhispererRuntimeClient::class, connectionSettings.withRegion(awsRegion)) | ||
|
|
||
| client.listAvailableProfilesPaginator {} | ||
| .profiles() | ||
| .map { p -> QRegionProfile(arn = p.arn(), profileName = p.profileName() ?: "<no name>") } | ||
| } | ||
| return mappedProfiles | ||
| } | ||
|
|
||
| override fun expiry(): Duration = Duration.ofSeconds(60) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this be too low?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bringing this up! Do you have a value in mind that you think would be more appropriate?