fix(amazonq): confusing message during loading profiles #5552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...at/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/QLoginWebview.kt
Fixed
Show fixed
Hide fixed
rli
reviewed
Apr 10, 2025
| // TODO: design and improve the API here | ||
|
|
||
| prepareUi(state: BrowserSetupData) { | ||
| prepareUi(state: any) { |
|
|
||
| private fun handleListProfilesMessage() { | ||
| ApplicationManager.getApplication().executeOnPooledThread { | ||
| var errorMessage: String = "" |
Contributor
There was a problem hiding this comment.
Suggested change
| var errorMessage: String = "" | |
| var errorMessage = "" |
Will-ShaoHua
changed the title
Will-ShaoHua
commented
Apr 10, 2025
Comment on lines
+290
to
+301
| { | ||
| stage: '$stage', | ||
| regions: $regions, | ||
| idcInfo: { | ||
| profileName: '${lastLoginIdcInfo.profileName}', | ||
| startUrl: '${lastLoginIdcInfo.startUrl}', | ||
| region: '${lastLoginIdcInfo.region}' | ||
| }, | ||
| cancellable: ${state.browserCancellable}, | ||
| feature: '${state.feature}', | ||
| existConnections: ${writeValueAsString(selectionSettings.values.map { it.currentSelection }.toList())}, | ||
| } |
Contributor
Author
There was a problem hiding this comment.
want to make all these messages from ide to webview typesafe as well, future work
Will-ShaoHua
commented
Apr 10, 2025
Comment on lines
+351
to
+356
| { | ||
| stage: 'PROFILE_SELECT', | ||
| status: '${if (profiles != null) "succeeded" else "failed"}', | ||
| profiles: ${writeValueAsString(profiles ?: "")}, | ||
| errorMessage: '$errorMessage' | ||
| } |
Contributor
Author
There was a problem hiding this comment.
ideally should polymorphism but haven't got enough time to figure it out
rli
approved these changes
Apr 10, 2025
Will-ShaoHua
added a commit
to Will-ShaoHua/aws-toolkit-jetbrains
that referenced
this pull request
Apr 10, 2025
rli
added a commit
that referenced
this pull request
Apr 10, 2025
Co-authored-by: Richard Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.