Skip to content

fix(amazonq): profile retry flow broke by #5552 #5556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 10, 2025
Merged

fix(amazonq): profile retry flow broke by #5552 #5556

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a797ea4
fix retry flow broke by #5552
Will-ShaoHua Apr 10, 2025
8e0af93
Merge remote-tracking branch 'upstream/main' into retry-flow
Will-ShaoHua Apr 10, 2025
24efda3
Merge branch 'main' into retry-flow
rli Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion plugins/core/webview/src/q-ui/components/profileSelection.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ export default defineComponent({
},
computed: {
isWaitingResponse() {
this.errorMessage = ''
const profileResult = this.$store.state.listProfilesResult
if (profileResult instanceof ListProfilePendingResult) {
return true
Expand All @@ -95,6 +96,7 @@ export default defineComponent({
this.availableProfiles = profileResult.profiles
} else if (profileResult instanceof ListProfileFailureResult) {
this.errorMessage = GENERIC_PROFILE_LOAD_ERROR
this.isRefreshing = false
} else {
// should not be this path
this.errorMessage = "Unexpected error happenede while loading Q Webview page"
Expand Down Expand Up @@ -124,7 +126,7 @@ export default defineComponent({
},
handleRetryClick() {
this.isRefreshing = true
window.ideApi.postMessage({command: 'prepareUi'})
Copy link
Contributor Author

@Will-ShaoHua Will-ShaoHua Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prepareUi will not pull profile anymore

window.ideApi.postMessage({command: 'listProfiles'})
},
handleSignoutClick() {
window.ideApi.postMessage({command: 'signout'})
Expand Down
Loading