feat(amazonq): client emits endChat when conversation ended #5572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Flare' into manodnyb/setupChatComponentsWithFlare
…Flare' into manodnyb/setupChatComponentsWithFlare
…p-endChat # Conflicts: # plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/webview/BrowserConnector.kt
…tions' into samgst/q-lsp-endChat # Conflicts: # plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/webview/BrowserConnector.kt # plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLanguageServer.kt # plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/model/aws/chat/FlareChatCommands.kt
Qodana Community for JVM3 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| import kotlinx.coroutines.flow.launchIn | ||
| import kotlinx.coroutines.flow.merge | ||
| import kotlinx.coroutines.flow.onEach | ||
| import kotlinx.coroutines.future.await |
Check warning
Code scanning / QDJVMC
Unused import directive Warning
|
|
||
| fun getAwsServerCapabilities(): AwsServerCapabilities? = awsServerCapabilities | ||
|
|
||
| fun setAwsServerCapabilities(awsServerCapabilities: AwsServerCapabilities?) { |
Check warning
Code scanning / QDJVMC
Unused symbol Warning
| val tabId: String, | ||
| ) | ||
|
|
||
| data class EndChatResult( |
Check warning
Code scanning / QDJVMC
Unused symbol Warning
samgst-amazon
changed the title
samgst-amazon
changed the base branch from
feature/q-lsp-chat
to
manodnyb/addQuickActions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles the endChat command
Types of changes
Description
Handle "aws/chat/endChat" by sending the server a request and removing the tab from the ChatPartialResultMap if present.
Implemented with changes from: #5561
EndChat is not currently hooked up on FLARE side, so this may need to change depending on how they implement it:
aws/language-servers#433
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.