Skip to content

fix(amazonq): /help does nothing in welcome page v2 #5588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from

Conversation

Will-ShaoHua
Copy link
Contributor

@Will-ShaoHua Will-ShaoHua commented Apr 16, 2025

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Before

Screen.Recording.2025-04-16.at.1.07.47.PM.mov

After

Screen.Recording.2025-04-16.at.1.05.31.PM.mov

VSC

vscode-help.mov

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Will-ShaoHua
Copy link
Contributor Author

Will-ShaoHua commented Apr 16, 2025

prefer this over #5577 , but not sure if this is the correct way

@Will-ShaoHua Will-ShaoHua marked this pull request as ready for review April 16, 2025 20:08
@Will-ShaoHua Will-ShaoHua requested a review from a team as a code owner April 16, 2025 20:08
@Will-ShaoHua Will-ShaoHua requested a review from a team as a code owner April 16, 2025 20:16
Comment on lines +227 to +239
case 'welcome':
this.tabsStorage.updateTabTypeFromUnknown(tabID, 'cwc')
this.tabsStorage.updateTabContent(tabID, {
tabHeaderDetails: void 0,
compactMode: false,
tabBackground: false,
promptInputText: '',
promptInputLabel: void 0,
chatItems: [],
tabTitle: 'Chat',
})
this.cwChatConnector.help(tabID)
break
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant