Skip to content

feat(amazonq): Inline E2E flow using flare #5629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
May 2, 2025
Merged

feat(amazonq): Inline E2E flow using flare #5629

merged 21 commits into from
May 2, 2025

Conversation

@andrewyuq
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 23, 2025
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 28, 2025
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 28, 2025
View reviewed changes
.../aws/toolkits/jetbrains/services/codewhisperer/telemetry/CodeWhispererTelemetryServiceNew.kt
acceptedCharCount
fun sendUserTriggerDecisionEvent(project: Project, latencyContext: LatencyContext) {
AmazonQLspService.executeIfRunning(project) { server ->
CodeWhispererServiceNew.getInstance().getAllPaginationSessions().forEach { jobId, state ->

Check notice

Code scanning / QDJVMC

Java Map.forEach method call should be replaced with Kotlin's forEach Note

Java Map.forEach method call should be replaced with Kotlin's forEach
@andrewyuq andrewyuq marked this pull request as ready for review April 30, 2025 13:28
@andrewyuq andrewyuq requested review from a team as code owners April 30, 2025 13:28
rli
rli reviewed May 1, 2025
View reviewed changes
...oftware/aws/toolkits/jetbrains/services/amazonqCodeTest/controller/CodeTestChatController.kt
LOG.debug { "Original code content from reference span: $originalContent" }
withContext(EDT) {
manager.addReferenceLogPanelEntry(reference = reference, null, null, originalContent?.split("\n"))
// TODO flare: hook /test references with flare correctly, this is only a compile error fix which is not tested
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how should we track this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add a line item in /test section in the doc

...y/src/software/aws/toolkits/jetbrains/services/codewhisperer/service/CodeWhispererService.kt
Comment on lines +641 to +645
textDocument = TextDocumentIdentifier(toUriString(editor.virtualFile))
position = Position(
editor.caretModel.primaryCaret.logicalPosition.line,
editor.caretModel.primaryCaret.logicalPosition.column
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont we have a util for this already?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't find one in the codebase
we have CaretPosition dataclass but that's for visualPosition, for poup displaying purpose.

@andrewyuq andrewyuq requested review from a team as code owners May 2, 2025 13:36
@andrewyuq andrewyuq changed the title Inline E2E flow using flare feat(amazonq): Inline E2E flow using flare May 2, 2025
manodnyab
manodnyab approved these changes May 2, 2025
View reviewed changes
...e/aws/toolkits/jetbrains/services/amazonq/lsp/textdocument/TextDocumentServiceHandlerTest.kt
private lateinit var mockTextDocumentService: TextDocumentService
private lateinit var sut: TextDocumentServiceHandler
private lateinit var mockApplication: Application
// private lateinit var mockApplication: Application
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: delete?

...tware/aws/toolkits/jetbrains/services/amazonq/lsp/textdocument/TextDocumentServiceHandler.kt
}
}
}
// Process document changes here
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a TODO?

@manodnyab
Copy link
Contributor

/retryBuilds

@manodnyab manodnyab merged commit 2e0fdf7 into aws:feature/q-lsp-chat May 2, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rli rli rli approved these changes

@manodnyab manodnyab manodnyab approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewyuq @manodnyab @rli