Skip to content

Conversation

@manodnyab
Copy link
Contributor

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@manodnyab manodnyab requested review from a team as code owners May 1, 2025 01:03
@github-actions
Copy link

github-actions bot commented May 1, 2025

Qodana Community for JVM

5 new problems were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 4
Unused import directive 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

import kotlinx.coroutines.flow.launchIn
import kotlinx.coroutines.flow.merge
import kotlinx.coroutines.flow.onEach
import kotlinx.coroutines.future.await

Check warning

Code scanning / QDJVMC

Unused import directive Warning

Unused import directive
}

enum class SerializedChatFormat(val value: String) {
HTML("html"),

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Class "HTML" is never used

enum class SerializedChatFormat(val value: String) {
HTML("html"),
MARKDOWN("markdown"),

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Class "MARKDOWN" is never used
val content: String,
)

data class GetSerializedChatRequest(

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Class "GetSerializedChatRequest" is never used
}

enum class TabBarAction(val value: String) {
EXPORT("export"),

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Class "EXPORT" is never used
AsyncChatUiListener.notifyPartialMessageUpdate(uiMessage)
}
}
companion object {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be in companion object? I moved my openTab map into ChatCommunicationManager but just made it part of the class.
https://github.com/aws/aws-toolkit-jetbrains/pull/5658/files

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-- might be going away anyways. I'll move mine to companion so we are aligned

@manodnyab manodnyab merged commit 95a5d34 into feature/q-lsp-chat May 1, 2025
14 of 16 checks passed
@manodnyab manodnyab deleted the manodnyb/addSaveAndExport branch May 1, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants