Skip to content

refacotr(amazonq): reduce extra call of listAvailableCustomization #5677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2025
Merged

refacotr(amazonq): reduce extra call of listAvailableCustomization #5677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee02a65
reduce extra call of listAvailableCustomization
Will-ShaoHua May 6, 2025
ce9e49a
test
Will-ShaoHua May 6, 2025
da381e9
Merge remote-tracking branch 'upstream/main' into throttle
Will-ShaoHua May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ...toolkits/jetbrains/services/codewhisperer/customization/CodeWhispererModelConfigurator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,7 @@ class DefaultCodeWhispererModelConfigurator : CodeWhispererModelConfigurator, Pe
QRegionProfileSelectedListener.TOPIC,
object : QRegionProfileSelectedListener {
override fun onProfileSelected(project: Project, profile: QRegionProfile?) {
pluginAwareExecuteOnPooledThread {
CodeWhispererModelConfigurator.getInstance().listCustomizations(project, passive = true)
}
switchCustomization(project, null)
}
}
)
Expand Down
4 changes: 2 additions & 2 deletions ...tware/aws/toolkits/jetbrains/services/codewhisperer/CodeWhispererModelConfiguratorTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,7 +615,7 @@ class CodeWhispererModelConfiguratorTest {
}

@Test
fun `profile switch should keep using existing customization if new list still contains that arn`() {
fun `should switch to default customization on profile changed`() {
val ssoConn = spy(LegacyManagedBearerSsoConnection(region = "us-east-1", startUrl = "url 1", scopes = Q_SCOPES))
ToolkitConnectionManager.getInstance(projectRule.project).switchConnection(ssoConn)
val oldCustomization = CodeWhispererCustomization("oldArn", "oldName", "oldDescription")
Expand All @@ -632,7 +632,7 @@ class CodeWhispererModelConfiguratorTest {
.syncPublisher(QRegionProfileSelectedListener.TOPIC)
.onProfileSelected(projectRule.project, null)

assertThat(sut.activeCustomization(projectRule.project)).isEqualTo(oldCustomization)
assertThat(sut.activeCustomization(projectRule.project)).isEqualTo(null)
}

@Test
Expand Down
Loading