Skip to content

feat(amazonq): add inline completion support of abap language (.abap/.adcs extensions) #5718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 15, 2025
Merged

feat(amazonq): add inline completion support of abap language (.abap/.adcs extensions) #5718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8988d3c
add inline completion support of abap language (.abap/.adcs extensions)
Will-ShaoHua May 12, 2025
fc942ad
telemetry bump
Will-ShaoHua May 14, 2025
7b0fd8c
typo
Will-ShaoHua May 14, 2025
b2e010e
changelog
Will-ShaoHua May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .changes/next-release/feature-eeb9909f-8f63-4bd7-8161-df8ca27dd953.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"type" : "feature",
"description" : "Add inline completion support for abap language"
}
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ mockitoKotlin = "5.4.0"
mockk = "1.13.17"
nimbus-jose-jwt = "9.40"
node-gradle = "7.0.2"
telemetryGenerator = "1.0.310"
telemetryGenerator = "1.0.322"
testLogger = "4.0.0"
testRetry = "1.5.10"
# test-only; platform provides slf4j transitively at runtime
Expand Down
2 changes: 2 additions & 0 deletions ...re/aws/toolkits/jetbrains/services/codewhisperer/language/CodeWhispererLanguageManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import com.intellij.openapi.components.Service
import com.intellij.openapi.components.service
import com.intellij.openapi.vfs.VirtualFile
import com.intellij.psi.PsiFile
import software.aws.toolkits.jetbrains.services.codewhisperer.language.languages.CodeWhispererAbap
import software.aws.toolkits.jetbrains.services.codewhisperer.language.languages.CodeWhispererC
import software.aws.toolkits.jetbrains.services.codewhisperer.language.languages.CodeWhispererCpp
import software.aws.toolkits.jetbrains.services.codewhisperer.language.languages.CodeWhispererCsharp
Expand Down Expand Up @@ -147,6 +148,7 @@ class CodeWhispererLanguageManager {
listOf("vue") to CodeWhispererVue.INSTANCE,
listOf("ps1", "psm1") to CodeWhispererPowershell.INSTANCE,
listOf("r") to CodeWhispererR.INSTANCE,
listOf("abap", "acds") to CodeWhispererAbap.INSTANCE,
).map {
val exts = it.first
val lang = it.second
Expand Down
21 changes: 21 additions & 0 deletions ...are/aws/toolkits/jetbrains/services/codewhisperer/language/languages/CodeWhispererAbap.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
// Copyright 2025 Amazon.com, Inc. or its affiliates. All Rights Reserved.
// SPDX-License-Identifier: Apache-2.0

package software.aws.toolkits.jetbrains.services.codewhisperer.language.languages

import software.aws.toolkits.jetbrains.services.codewhisperer.language.CodeWhispererProgrammingLanguage
import software.aws.toolkits.telemetry.CodewhispererLanguage

class CodeWhispererAbap private constructor() : CodeWhispererProgrammingLanguage() {
override val languageId: String = ID

override fun toTelemetryType(): CodewhispererLanguage = CodewhispererLanguage.Abap

override fun isCodeCompletionSupported(): Boolean = true

companion object {
const val ID = "abap"

val INSTANCE = CodeWhispererAbap()
}
}
1 change: 0 additions & 1 deletion ...ftware/aws/toolkits/jetbrains/services/codewhisperer/language/languages/CodeWhispererR.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ class CodeWhispererR private constructor() : CodeWhispererProgrammingLanguage()
override fun isCodeCompletionSupported(): Boolean = true

companion object {
// TODO: confirm with service team language id
const val ID = "r"

val INSTANCE = CodeWhispererR()
Expand Down
2 changes: 2 additions & 0 deletions ...oftware/aws/toolkits/jetbrains/services/codewhisperer/CodeWhispererLanguageManagerTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import org.mockito.kotlin.doReturn
import org.mockito.kotlin.mock
import software.aws.toolkits.jetbrains.services.codewhisperer.language.CodeWhispererLanguageManager
import software.aws.toolkits.jetbrains.services.codewhisperer.language.CodeWhispererProgrammingLanguage
import software.aws.toolkits.jetbrains.services.codewhisperer.language.languages.CodeWhispererAbap
import software.aws.toolkits.jetbrains.services.codewhisperer.language.languages.CodeWhispererC
import software.aws.toolkits.jetbrains.services.codewhisperer.language.languages.CodeWhispererCpp
import software.aws.toolkits.jetbrains.services.codewhisperer.language.languages.CodeWhispererCsharp
Expand Down Expand Up @@ -136,6 +137,7 @@ class CodeWhispererLanguageManagerTest {
testGetProgrammingLanguageUtil<CodeWhispererSwift>(listOf("foo"), listOf("swift"))
testGetProgrammingLanguageUtil<CodeWhispererSystemVerilog>(listOf("foo"), listOf("sv", "svh", "vh"))
testGetProgrammingLanguageUtil<CodeWhispererVue>(listOf("foo"), listOf("vue"))
testGetProgrammingLanguageUtil<CodeWhispererAbap>(listOf("foo"), listOf("abap", "acds"))
}

@Test
Expand Down
Loading