Skip to content

Conversation

LiGaCu
Copy link
Contributor

@LiGaCu LiGaCu commented May 16, 2025

Problem

AmazonQ LSP needs an identifier for the IDE workspace, which should be stable and unique for each workspace, regardless of IDE restarts or system reboots.

Related aws/language-server-runtimes change:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Use Project.getBasePath() as such an identifier and pass it when initializing AmazonQ language server.

Similar change on aws/aws-toolkit-vscode side:

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@LiGaCu LiGaCu requested a review from a team as a code owner May 16, 2025 07:02
@LiGaCu LiGaCu force-pushed the workspace_identifier branch from 70edcd6 to e103481 Compare May 16, 2025 07:52
)
),
contextConfiguration = ContextConfiguration(
workspaceIdentifier = project.getBasePath()

Check notice

Code scanning / QDJVMC

Accessor call that can be replaced with property access syntax Note

Use of getter method instead of property access syntax
@LiGaCu LiGaCu force-pushed the workspace_identifier branch from e103481 to ec53d15 Compare May 16, 2025 21:38
@rli rli merged commit 3c07c5b into aws:main May 16, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants