-
Notifications
You must be signed in to change notification settings - Fork 272
fix(amazonq): add retries for /transform APIs #5751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
3805f06
fix(amazonq): add retries for /transform APIs
058d228
set attempts to 4
3679de3
handle re-auth
21d3966
text change
bd6cbd7
minor text change
db33b04
minor text change
5abc53b
remove unused import
bcfeb21
add changelog
d4f9edf
fix test
766a1c3
log error
9079590
add log
a6092d5
add tests for retry logic
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,12 +30,12 @@ class RetryableOperation<T> { | |
isRetryable: (Exception) -> Boolean = { it is RetryableException }, | ||
errorHandler: (suspend (Exception, Int) -> Nothing), | ||
): T { | ||
while (attempts < MAX_RETRY_ATTEMPTS) { | ||
while (attempts < MAX_ATTEMPTS) { | ||
try { | ||
return operation() | ||
} catch (e: Exception) { | ||
attempts++ | ||
if (attempts >= MAX_RETRY_ATTEMPTS || !isRetryable(e)) { | ||
if (attempts >= MAX_ATTEMPTS || !isRetryable(e)) { | ||
errorHandler.invoke(e, attempts) | ||
} | ||
delay(getJitteredDelay()) | ||
|
@@ -48,6 +48,6 @@ class RetryableOperation<T> { | |
companion object { | ||
private const val INITIAL_DELAY = 100L | ||
private const val MAX_BACKOFF = 10000L | ||
private const val MAX_RETRY_ATTEMPTS = 3 | ||
private const val MAX_ATTEMPTS = 4 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm guessing the intention was to do 3 retries (after the initial attempt), meaning this should technically be set to 4, and naming it |
||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the same retry strategy from:
aws-toolkit-jetbrains/plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/clients/AmazonQStreamingClient.kt
Lines 82 to 89 in ebece9d
in the
ExportResultArchive
(download) APIand added
SocketTimeoutException
(which is not a type ofTimeoutException
, so it needs to be explicitly listed here)