Skip to content

fix(amazonq): add range field to indicate partial doc change #5767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025
Merged

fix(amazonq): add range field to indicate partial doc change #5767

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbcfac1
fix(amazonq): add range field to indicate partial doc change
andrewyuq May 30, 2025
a6baf04
detekt
andrewyuq May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ...re/aws/toolkits/jetbrains/services/amazonq/lsp/textdocument/TextDocumentServiceHandler.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ import org.eclipse.lsp4j.DidChangeTextDocumentParams
import org.eclipse.lsp4j.DidCloseTextDocumentParams
import org.eclipse.lsp4j.DidOpenTextDocumentParams
import org.eclipse.lsp4j.DidSaveTextDocumentParams
import org.eclipse.lsp4j.Position
import org.eclipse.lsp4j.Range
import org.eclipse.lsp4j.TextDocumentContentChangeEvent
import org.eclipse.lsp4j.TextDocumentIdentifier
import org.eclipse.lsp4j.TextDocumentItem
Expand Down Expand Up @@ -164,6 +166,9 @@ class TextDocumentServiceHandler(
pluginAwareExecuteOnPooledThread {
val vFile = FileDocumentManager.getInstance().getFile(event.document) ?: return@pluginAwareExecuteOnPooledThread
toUriString(vFile)?.let { uri ->
val editor = FileEditorManager.getInstance(project).selectedTextEditor ?: return@pluginAwareExecuteOnPooledThread
val logicalPosition = editor.offsetToLogicalPosition(event.offset)
val newLogicalPosition = editor.offsetToLogicalPosition(event.offset + event.newLength)
languageServer.textDocumentService.didChange(
DidChangeTextDocumentParams().apply {
textDocument = VersionedTextDocumentIdentifier().apply {
Expand All @@ -173,6 +178,10 @@ class TextDocumentServiceHandler(
contentChanges = listOf(
TextDocumentContentChangeEvent().apply {
text = event.newFragment.toString()
range = Range(
Position(logicalPosition.line, logicalPosition.column),
Position(newLogicalPosition.line, newLogicalPosition.column)
)
}
)
}
Expand Down
Loading