Skip to content

fix(amazonq): do not decode uri if window/showDocument is external #5776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025
Merged

fix(amazonq): do not decode uri if window/showDocument is external #5776

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...ity/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLanguageClientImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,14 +149,14 @@
return CompletableFuture.completedFuture(ShowDocumentResult(false))
}

// The filepath sent by the server contains unicode characters which need to be
// decoded for JB file handling APIs to be handle to handle file operations
val fileToOpen = URLDecoder.decode(params.uri, StandardCharsets.UTF_8.name())
if (params.external == true) {
BrowserUtil.open(fileToOpen)
BrowserUtil.open(params.uri)

Check warning on line 153 in plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLanguageClientImpl.kt

View check run for this annotation

Codecov / codecov/patch

plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLanguageClientImpl.kt#L153 

Added line #L153 was not covered by tests
return CompletableFuture.completedFuture(ShowDocumentResult(true))
}

// The filepath sent by the server contains unicode characters which need to be
// decoded for JB file handling APIs to be handle to handle file operations
val fileToOpen = URLDecoder.decode(params.uri, StandardCharsets.UTF_8.name())

Check warning on line 159 in plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLanguageClientImpl.kt

View check run for this annotation

Codecov / codecov/patch

plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLanguageClientImpl.kt#L159 

Added line #L159 was not covered by tests
ApplicationManager.getApplication().invokeLater {
try {
val virtualFile = VirtualFileManager.getInstance().findFileByUrl(fileToOpen)
Expand Down
Loading