-
Notifications
You must be signed in to change notification settings - Fork 272
feat(amazonq): expose 'Manage Subscriptions' action for builder id paid tier #5777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...ity/src/software/aws/toolkits/jetbrains/services/codewhisperer/actions/ManageSubscription.kt
Outdated
Show resolved
Hide resolved
|
||
if (connection != null) { | ||
if (!connection.isSono()) { | ||
add(actionManager.getAction("codewhisperer.switchProfiles")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not keep using add(QSwitchProfilesAction())
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
marginally saves some GC cycles because we dont need to construct/gc
Qodana Community for JVM1 new problem were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
...ity/src/software/aws/toolkits/jetbrains/services/codewhisperer/actions/ManageSubscription.kt
Fixed
Show fixed
Hide fixed
|
||
override fun actionPerformed(e: AnActionEvent) { | ||
val project = e.project ?: return | ||
currentThreadCoroutineScope().launch { |
Check warning
Code scanning / QDJVMC
Unstable API Usage Warning
AmazonQLspService.getInstance(project).execute { lsp -> | ||
lsp.workspaceService.executeCommand( | ||
ExecuteCommandParams().apply { | ||
this.command = "aws/chat/manageSubscription" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirming if this works even if auth is not migrated to Flare? Is there any step that would require regular builder id auth?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
auth is not involved at all
the upgrade flow is in the browser. the flow is
extension to Flare: workspace/executeCommand (aws/chat/manageSubscription)
Flare: does some logic
Flare to extension: window/showDocument (isExternal)
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.