Skip to content

Conversation

manodnyab
Copy link
Contributor

@manodnyab manodnyab commented Jun 4, 2025

Description

The active editor window wasn't being sent in the correct nested object hence no active file was ever detected

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@manodnyab manodnyab requested a review from a team as a code owner June 4, 2025 07:04
Copy link

github-actions bot commented Jun 4, 2025

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]


val serializedEnrichmentParams = serializer.objectMapper.valueToTree<ObjectNode>(enrichmentParams)
val chatParams: ObjectNode = (node as ObjectNode)
val chatParams: ObjectNode = (node.params as ObjectNode)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the type need to change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the type needs to be object node as that turns it into a mutable object. Here node and node.params have the same type!

@manodnyab manodnyab enabled auto-merge (squash) June 4, 2025 16:18
@manodnyab manodnyab merged commit 38e7369 into feature/q-lsp-chat Jun 4, 2025
14 of 16 checks passed
@manodnyab manodnyab deleted the manodnyb/figureOutActiveFile branch June 4, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants