fix(amazonq): make q chat unavalable in IDE version 2024.2.1 #5788
Conversation
| q.sign.in=Get Started | ||
| q.ui.prompt.transform=/transform | ||
| q.unavailable=\ Not supported in v2023.2.0 | ||
| q.unavailable=\ Q Chat not supported in v2024.2.1 |
There was a problem hiding this comment.
| q.unavailable=\ Q Chat not supported in v2024.2.1 | |
| q.unavailable=\ Amazon Q Chat not supported in v2024.2.1 |
|
|
||
| fun isQSupportedInThisVersion(): Boolean = ApplicationInfo.getInstance().build.asStringWithoutProductCode() !in unSupportedIdeVersionInQ | ||
|
|
||
| val unSupportedIdeVersionInQ = listOf("242.21829.142") |
There was a problem hiding this comment.
can we do startswith 242.1, as in do we know for sure it's only this specific version?
There was a problem hiding this comment.
mv == "242" && version < 242.22855.74?
There was a problem hiding this comment.
242.21829.142 maps to 242.1
242.22855.74 is 242.2
There was a problem hiding this comment.
changed to check for earlier 242 versions.
|
nit: should we say |
Qodana Community for JVM1 new problem were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
| } | ||
|
|
||
| override fun shouldBeAvailable(project: Project): Boolean = isQWebviewsAvailable() | ||
| override fun shouldBeAvailable(project: Project): Boolean = isQWebviewsAvailable() && isQSupportedInThisVersion() |
There was a problem hiding this comment.
doesnt this prevent the panel from being available at all?
There was a problem hiding this comment.
I only added this because I saw it here: https://github.com/aws/aws-toolkit-jetbrains-staging/pull/1769/files
but you're right when its true it removes the Q chat panel completely. Too confusing for cxs.
|
|
||
| fun isQSupportedInThisVersion(): Boolean = ApplicationInfo.getInstance().build.asStringWithoutProductCode() !in unSupportedIdeVersionInQ | ||
|
|
||
| val unSupportedIdeVersionInQ = listOf("242.21829.142") |
There was a problem hiding this comment.
mv == "242" && version < 242.22855.74?
|
Not producing notification/modal since we can just display the update message directly in the Q panel. |
…ailable' into samgst/q-lsp-chat-webview-not-available # Conflicts: # plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/QUtils.kt
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| return !( | ||
| currentBuild.baselineVersion == 242 && | ||
| BuildNumber.fromString("242.22855.74")?.let { currentBuild.compareTo(it) < 0 } == true |
Check notice
Code scanning / QDJVMC
Can be replaced with binary operator Note
...nq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/QUtils.kt
Outdated
Show resolved
Hide resolved
…olkits/jetbrains/services/amazonq/QUtils.kt Co-authored-by: Richard Li <[email protected]>
plugins/core/resources/resources/software/aws/toolkits/resources/MessagesBundle.properties
Outdated
Show resolved
Hide resolved
…es/MessagesBundle.properties
…ailable' into samgst/q-lsp-chat-webview-not-available
|
/retryBuilds |
4 participants
Types of changes
Description
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.