Skip to content

Conversation

manodnyab
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

aws-toolkit-automation and others added 30 commits April 10, 2025 17:13
* Set up Flare chat connection

* Partial chat results

* feedback

* detekt

* syntax error

* detekt

* detekt
 Conflicts:
	plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLanguageServer.kt
* Set up Flare chat connection

* Partial chat results

* feedback

* detekt

* syntax error

* detekt

* detekt

* Add quick actions to chat

* adding commands from initialize result

* added trace logging

* Feedback

* detekt
…n chat (#5608)

* Set up Flare chat connection

* Partial chat results

* feedback

* detekt

* syntax error

* detekt

* detekt

* Add quick actions to chat

* adding commands from initialize result

* added trace logging

* link click events

* feedback

* rename

* missing license

---------

Co-authored-by: Manodnya Bhoite <[email protected]>
Co-authored-by: manodnyab <[email protected]>
* Set up Flare chat connection

* Partial chat results

* feedback

* detekt

* syntax error

* detekt

* detekt

* Add quick actions to chat

* adding commands from initialize result

* added trace logging

* add aws/chat/ready

* feedback

* detekt

---------

Co-authored-by: Manodnya Bhoite <[email protected]>
Co-authored-by: manodnyab <[email protected]>
andrewyuq and others added 20 commits May 30, 2025 13:30
* fix(amazonq): add range field to indicate partial doc change

For the LSP's TextDocumentContentChangeEvent, if range is not specified, LSP would assume the contentChange is for the whole file and replace the file content with it, so if user is just making edits we need to specify range other wise file content will be replaced by this diff.

* detekt
Fixed a race condition between two streams receiving cancellation information. Previously, if the CancellationException from the sendChatPrompt stream was processed before the "You stopped your work" message from the partialResult stream, the UI would not properly display the stop message.

The fix prioritizes stop messages by checking for them before acquiring any locks, ensuring they're processed immediately when detected. This allows the cancellation to complete properly regardless of which stream receives information first.

Key changes:

* Added special case handling for stop messages before lock acquisition
* Immediately mark final result as processed when stop message is detected
* Set result in ChatAsyncResultManager to coordinate between streams

This ensures a consistent user experience when cancelling operations, with the stop message always being displayed properly.
…input box (#5766)

Fixing the bg colors again by forcing a lighter color for the text box (based on a luma calculation)
)

* added background color for text boxes

* detekt

* update

* feedbak
don't block server startup if resolution fails
…ate` from model selection pr (#5779)

lots of warnings because not currently handled
```
WARN - org.eclipse.lsp4j.jsonrpc.services.GenericEndpoint - Unsupported notification method: aws/chat/chatOptionsUpdate
```
There was a threading issue where since the file was opened in EDT and the result was sent back to the server on another thread, it returned the result before the file was opened. This PR makes it synchronous
…#5787)

* fix(amazonq): fix issue where chat messages get sent to all projects

* callsites

---------

Co-authored-by: manodnyab <[email protected]>
We need some visibility on how prevalent failures are
@manodnyab manodnyab requested review from a team as code owners June 5, 2025 09:15
Copy link

github-actions bot commented Jun 5, 2025

Qodana Community for JVM

101 new problems were found

Inspection name Severity Problems
Usage of API marked for removal 🔴 Failure 7
Unused symbol 🔶 Warning 80
Incorrect string capitalization 🔶 Warning 1
Extension class should be final and non-public 🔶 Warning 1
Serializable object must implement 'readResolve' 🔶 Warning 1
Unresolved reference in KDoc 🔶 Warning 1
Redundant 'suspend' modifier 🔶 Warning 1
Unstable API Usage 🔶 Warning 1
Variable initializer is redundant 🔶 Warning 1
Boolean literal argument without parameter name ◽️ Notice 2
Const property naming convention ◽️ Notice 2
Function or property has platform type ◽️ Notice 2
Accessor call that can be replaced with property access syntax ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QDJVMC found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

* make chat unaccessible on 242.2.1

* detekt

* feedback

* detekt

* alias

* simplify

* fix product code

* Update plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/QUtils.kt

Co-authored-by: Richard Li <[email protected]>

* update message

* Update plugins/core/resources/resources/software/aws/toolkits/resources/MessagesBundle.properties

* revert

---------

Co-authored-by: manodnyab <[email protected]>
Co-authored-by: Richard Li <[email protected]>
Copy link
Contributor

@saurabhajmera saurabhajmera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving merge to main

@manodnyab manodnyab merged commit d9c199d into main Jun 5, 2025
22 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants