fix(amazonq): skip inline completion when deleting #5874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will-ShaoHua
approved these changes
Jul 2, 2025
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...rc/software/aws/toolkits/jetbrains/services/codewhisperer/popup/QInlineCompletionProvider.kt
Fixed
Show fixed
Hide fixed
| } | ||
|
|
||
| fun InlineCompletionEvent.isDeletion(): Boolean = | ||
| this is InlineCompletionEvent.Backspace |
Check warning
Code scanning / QDJVMC
Unstable API Usage Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Previous before LSP inline completion migration, we do not make auto trigger when deleting characters. But after LSP inline migration, we are making such triggers. These triggers are not what backend expects, it triggers more, causing server side throttling, and the quality isn't good.
Now we are bringing back the previous auto trigger conditions.
This entire file does not have unit test and the getSuggestion method is integrated with JB inline completion API which makes it hard to add unit test. The test was done manually.
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.