fix(amazonq): add missing auth checks / invalidate token if server claims token is invalid #5876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aims token is invalid we have several existing checks to guard against invocation, but do not handle the case where token is no longer valid
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
|
Relevant: aws/aws-toolkit-vscode#7603 |
leigaol
approved these changes
Jul 3, 2025
leigaol
reviewed
Jul 3, 2025
| val project = editor.project ?: return InlineCompletionSuggestion.Empty | ||
|
|
||
| // try to refresh automatically if possible, otherwise ask user to login again | ||
| if (isQExpired(project)) { |
There was a problem hiding this comment.
this isQExpired should be very fast so that inline completion latency does not go up
There was a problem hiding this comment.
yes this is just check on token timestamp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we have several existing checks to guard against invocation, but do not handle the case where token is no longer valid
Types of changes
Description
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.