fix(amazonq): clear out cached supplier if connection is invalidated … #5881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/ clear tokens on InvalidGrantException when a user reauthenticates while reusing a connection, the cached supplier can incorrectly retain the last token instead of immediately returning the new one additionally, the cached supplier can infinitely attempt token refresh since we are retaining invalid tokens instead of destroying them
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
rli
force-pushed
the
rli/auth-supplier-fix
branch
from
522f5f3 to
7bc23fb
Compare
manodnyab
reviewed
Jul 8, 2025
| ?.tokenProvider | ||
| ?.delegate | ||
| ?.let { it as? BearerTokenProvider } ?: return@scheduleWithFixedDelay | ||
| tokenProvider.resolveToken() |
There was a problem hiding this comment.
does this attempt to use the cached supplier to refresh? should the refresh called be used here?
There was a problem hiding this comment.
cached supplier will refresh if needed
| this.lastToken.set(it) | ||
| } | ||
| } | ||
| override fun refresh(): AccessToken = supplier.supplier.refresh() |
There was a problem hiding this comment.
should this also refresh cached supplier?
manodnyab
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…/ clear tokens on InvalidGrantException
when a user reauthenticates while reusing a connection, the cached supplier can incorrectly retain the last token instead of immediately returning the new one
additionally, the cached supplier can infinitely attempt token refresh since we are retaining invalid tokens instead of destroying them
Types of changes
Description
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.