feat(amazonq): show the opt-in checkbox for server-side context #5894
+28
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rli
reviewed
Aug 11, 2025
| ToolkitConnectionManagerListener.TOPIC, | ||
| object : ToolkitConnectionManagerListener { | ||
| override fun activeConnectionChanged(newConnection: ToolkitConnection?) { | ||
| enabled(isCodeWhispererEnabled(project)) |
There was a problem hiding this comment.
Suggested change
| enabled(isCodeWhispererEnabled(project)) | |
| enabled(isCodeWhispererEnabled(project)) | |
| visibleIf(isInternalUser) |
There was a problem hiding this comment.
Tested the proposed changes and it doesn't work actually. That would always make the checkbox showing up no matter logging in with internal user identity or other identities.
rli
approved these changes
Aug 11, 2025
leigaol
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
We need to support client-side opt-out for internal users who have workspace context server running by default.
Tested together with the
aws/language-serverschange:Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.