fix(amazonq): insert to cursor button in chat applies edit to active file #5897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...ins-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/util/LspEditorUtil.kt
Fixed
Show fixed
Hide fixed
…o samgst/insert-to-cursor-fix
manodnyab
approved these changes
Jul 11, 2025
rli
reviewed
Jul 11, 2025
| val textDocument = editor?.let { TextDocumentIdentifier(toUriString(it.virtualFile)) } | ||
| val cursorPosition = editor?.let { LspEditorUtil.getCursorPosition(it) } | ||
| val enrichedParams = (node.params as? ObjectNode)?.apply { | ||
| set<JsonNode>("cursorPosition", serializer.objectMapper.valueToTree(cursorPosition)) |
There was a problem hiding this comment.
see SEND_CHAT_COMMAND_PROMPT to see how we can reduce number of serializer calls
| ) | ||
| } | ||
|
|
||
| fun applyWorkspaceEdit(project: Project, edit: WorkspaceEdit) { |
There was a problem hiding this comment.
follow up later with tests for at least this method
…o samgst/insert-to-cursor-fix
…o samgst/insert-to-cursor-fix
rli
reviewed
Jul 15, 2025
Comment on lines
+43
to
+45
| virtualFileManager = mockk(relaxed = true) | ||
| fileDocumentManager = mockk(relaxed = true) | ||
| fileEditorManager = mockk(relaxed = true) |
There was a problem hiding this comment.
take a look at CodeInsightTestFixture
rli
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clicking the
insert to cursoroption on code blocks generated in Q chat previously did not actually apply the change.This change now inserts the code block to the cursor position on the current active file in the editor.
Types of changes
Description
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.