Skip to content

Conversation

ctlai95
Copy link
Contributor

@ctlai95 ctlai95 commented Jul 14, 2025

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Related to aws/language-servers#1808

This change is to support the aws/chat/listAvailableModels lsp method

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ctlai95 ctlai95 requested review from a team as code owners July 14, 2025 21:32
const val LIST_RULES_REQUEST_METHOD = "aws/chat/listRules"
const val RULE_CLICK_REQUEST_METHOD = "aws/chat/ruleClick"

const val LIST_AVAILABLE_MODELS = "aws/chat/listAvailableModels"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can you please add this event in alphabetical order?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes more sense to sort these by features, and also the other methods are not in alphabetical order either

@ctlai95 ctlai95 merged commit ee1d809 into aws:main Jul 15, 2025
11 of 12 checks passed
@ctlai95 ctlai95 deleted the list-available-models branch July 15, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants