fix(amazonq): render drag&drop overlay and fix the issue that images … #5905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…added to pinned context from drag&drop
manodnyab
reviewed
Jul 24, 2025
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "type" : "bugfix", | |||
| "description" : "Fix the issue that sometime image added via drag & drop are incorrectly routing to pinned contexts and drag overlay is not rendered" | |||
There was a problem hiding this comment.
Suggested change
| "description" : "Fix the issue that sometime image added via drag & drop are incorrectly routing to pinned contexts and drag overlay is not rendered" | |
| "description" : "Fix the issue that sometime images added via drag & drop are incorrectly routed to pinned context" |
| val dropTarget = object : DropTarget() { | ||
| override fun dragEnter(dtde: DropTargetDragEvent) { | ||
| try { | ||
| browserInstance.jcefBrowser.cefBrowser.executeJavaScript( |
There was a problem hiding this comment.
can we extract this code out to a function since its the same code with one parameter changed?
manodnyab
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…added to pinned context from drag&drop
Fix the bugs
Depends on aws/mynah-ui#397
Types of changes
Description
@Pinned Contextmenu and dismissing it, as the signal remains in a true state instead of resetting.Screen.Recording.2025-07-15.at.3.25.34.PM.mov
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.