Skip to content

Conversation

samgst-amazon
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@samgst-amazon samgst-amazon requested a review from a team as a code owner July 18, 2025 17:11
@samgst-amazon samgst-amazon changed the title Add 252 EAP 6 profile build(252): Add 252 EAP 6 profile Jul 18, 2025
Copy link

github-actions bot commented Jul 18, 2025

Qodana Community for JVM

23 new problems were found

Inspection name Severity Problems
Unstable API Usage 🔴 Failure 3
Unstable API Usage 🔶 Warning 2
Companion object in extensions 🔶 Warning 1
Incorrect string capitalization 🔶 Warning 1
Extension class should be final and non-public 🔶 Warning 1
Nested lambda has shadowed implicit parameter ◽️ Notice 15

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@samgst-amazon samgst-amazon requested a review from a team as a code owner July 22, 2025 00:51

import com.intellij.openapi.project.DumbService
import com.intellij.openapi.project.DumbServiceImpl
import com.intellij.openapi.project.runInDumbMode
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for this split was that this import was causing issues on versions < 252

@Before
open fun setUp() = runTest {
mockLanguageServer = mockk()
VfsRootAccess.allowRootAccess(disposableRule.disposable, "/usr/bin", "/usr/local/bin", "C:/Program Files/pypy3.10-v7.3.17-win64")
Copy link
Contributor Author

@samgst-amazon samgst-amazon Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samgst-amazon samgst-amazon enabled auto-merge (squash) August 4, 2025 18:22
@samgst-amazon
Copy link
Contributor Author

/retryBuilds

@rli rli disabled auto-merge August 4, 2025 18:46
@rli rli merged commit 14c6726 into main Aug 4, 2025
18 of 24 checks passed
@rli rli deleted the samgst/bump-252 branch August 4, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants