Skip to content

feat(amazonq): Enable one-click collection of logs from chat #5923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Aug 7, 2025
Merged

feat(amazonq): Enable one-click collection of logs from chat #5923

merged 12 commits into from
Aug 7, 2025

Conversation

manodnyab
Copy link
Contributor

@manodnyab manodnyab commented Jul 24, 2025 •
edited
Loading

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Add the ability to collect logs from chat with one click

Screenshot 2025-07-31 at 4 36 25 PM Screenshot 2025-07-31 at 4 31 02 PM

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions GitHub Actions
Copy link

Qodana Community for JVM

4 new problems were found

Inspection name Severity Problems
Incorrect string capitalization 🔶 Warning 2
Unstable API Usage 🔶 Warning 2

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 24, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 25, 2025 •
edited
Loading

Qodana Community for JVM

4 new problems were found

Inspection name Severity Problems
Unstable API Usage 🔶 Warning 2
Companion object in extensions 🔶 Warning 1
Incorrect string capitalization 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@manodnyab manodnyab marked this pull request as ready for review July 30, 2025 18:05
@manodnyab manodnyab requested a review from a team as a code owner July 31, 2025 23:33
rli
rli reviewed Aug 6, 2025
View reviewed changes
...rains-community/src/software/aws/toolkits/jetbrains/services/amazonq/GetAmazonQLogsAction.kt Outdated
import software.aws.toolkits.resources.AmazonQBundle.message

class GetAmazonQLogsAction : DumbAwareAction(
AmazonQBundle.message("amazonq.getLogs.tooltip.text")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also see: https://plugins.jetbrains.com/docs/intellij/action-system.html#localizing-actions-and-groups

...rains-community/src/software/aws/toolkits/jetbrains/services/amazonq/GetAmazonQLogsAction.kt Outdated

override fun update(e: AnActionEvent) {
super.update(e)
val baseIcon = IconLoader.getIcon("/icons/file.svg", GetAmazonQLogsAction::class.java)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

icon loader has a cache, but load the icon once in the action initialization so we are not constantly trying to do this on EDT

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving the value to class variables and updating the usage in update

...rains-community/src/software/aws/toolkits/jetbrains/services/amazonq/GetAmazonQLogsAction.kt Outdated
Comment on lines 47 to 49
val action = ActionManager.getInstance().getAction("CollectZippedLogs")
val datacontxt = SimpleDataContext.builder().add(CommonDataKeys.PROJECT, project).build()
val ae = AnActionEvent.createEvent(action, datacontxt, null, ActionPlaces.UNKNOWN, ActionUiKind.POPUP, null)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is technically internal so we should have a test

...rains-community/src/software/aws/toolkits/jetbrains/services/amazonq/GetAmazonQLogsAction.kt Outdated
fun showLogCollectionWarningGetLogs(project: Project) {
try {
val action = ActionManager.getInstance().getAction("CollectZippedLogs")
val datacontxt = SimpleDataContext.builder().add(CommonDataKeys.PROJECT, project).build()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
val datacontxt = SimpleDataContext.builder().add(CommonDataKeys.PROJECT, project).build()
val dataContext = SimpleDataContext.builder().add(CommonDataKeys.PROJECT, project).build()

github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 7, 2025
View reviewed changes
...rains-community/src/software/aws/toolkits/jetbrains/services/amazonq/GetAmazonQLogsAction.kt
showLogCollectionWarningGetLogs(project)
}

companion object {

Check warning

Code scanning / QDJVMC

Companion object in extensions Warning

Companion objects in IDE extension implementations may only contain a logger and constants
...rains-community/src/software/aws/toolkits/jetbrains/services/amazonq/GetAmazonQLogsAction.kt
fun showLogCollectionWarningGetLogs(project: Project) {
if (Messages.showOkCancelDialog(
message("amazonq.logs.warning"),
message("amazonq.getLogs"),

Check warning

Code scanning / QDJVMC

Incorrect string capitalization Warning

String 'Get Amazon Q logs' is not properly capitalized. It should have title capitalization
...rains-community/src/software/aws/toolkits/jetbrains/services/amazonq/GetAmazonQLogsAction.kt
runUnderProgressIfNeeded(project, message("amazonq.getLogs"), cancelable = true) {
runBlocking {
try {
RevealFileAction.openFile(LogPacker.packLogs(project))

Check warning

Code scanning / QDJVMC

Unstable API Usage Warning

'com.intellij.ide.logsUploader.LogPacker' is marked unstable with @ApiStatus.Internal
...rains-community/src/software/aws/toolkits/jetbrains/services/amazonq/GetAmazonQLogsAction.kt
runUnderProgressIfNeeded(project, message("amazonq.getLogs"), cancelable = true) {
runBlocking {
try {
RevealFileAction.openFile(LogPacker.packLogs(project))

Check warning

Code scanning / QDJVMC

Unstable API Usage Warning

'packLogs(com.intellij.openapi.project.Project, kotlin.coroutines.Continuation)' is declared in unstable 'com.intellij.ide.logsUploader.LogPacker' marked with @ApiStatus.Internal
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Investigating moving to another action in a follow up PR

@manodnyab manodnyab merged commit b66fb94 into main Aug 7, 2025
23 of 24 checks passed
@manodnyab manodnyab deleted the manodnyb/fixThinkingBug branch August 7, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rli rli rli approved these changes

@samgst-amazon samgst-amazon samgst-amazon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@manodnyab @rli @samgst-amazon @laileni-aws