-
Notifications
You must be signed in to change notification settings - Fork 267
build: Remove usages of deprecated API in DatabaseAuthProvider #5945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Qodana Community for JVM9 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
import software.aws.toolkits.resources.message | ||
import javax.swing.JPanel | ||
|
||
abstract class AwsAuthWidget(private val userFieldEnabled: Boolean = true) : DatabaseCredentialsAuthProviderUi.UserWidget() { |
Check failure
Code scanning / QDJVMC
Usage of API marked for removal Error
|
||
override fun createPanel(): JPanel { | ||
val panel = JPanel(GridLayoutManager(rowCount, columnCount)) | ||
addUserField(panel, 0) |
Check failure
Code scanning / QDJVMC
Usage of API marked for removal Error
addUserField(panel, 0) | ||
|
||
// Disable the user field if we treat it as immutable | ||
myUserField.isEnabled = userFieldEnabled |
Check failure
Code scanning / QDJVMC
Usage of API marked for removal Error
super.reset(point, resetCredentials) | ||
reset(point.dataSource, resetCredentials) | ||
override fun reset(config: DatabaseConnectionPoint, resetCredentials: Boolean) { | ||
super.reset(config, resetCredentials) |
Check failure
Code scanning / QDJVMC
Usage of API marked for removal Error
override fun onChanged(r: Runnable) { | ||
// Tries to set username so if we don't have one, don't set | ||
if (userFieldEnabled) { | ||
super.onChanged(r) |
Check failure
Code scanning / QDJVMC
Usage of API marked for removal Error
override fun onChanged(r: Runnable) { | ||
// Tries to set username so if we don't have one, don't set | ||
if (userFieldEnabled) { | ||
super.onChanged(r) |
Check failure
Code scanning / QDJVMC
Usage of API marked for removal Error
region?.let { | ||
regionSelector.selectedRegion = it | ||
} | ||
super.updateFromUrl(holder) |
Check failure
Code scanning / QDJVMC
Usage of API marked for removal Error
region?.let { | ||
regionSelector.selectedRegion = it | ||
} | ||
super.updateFromUrl(holder) |
Check failure
Code scanning / QDJVMC
Usage of API marked for removal Error
/retryBuilds |
Types of changes
Description
from #5774 :
DataGrip team is making changes in DatabaseAuthProvider API, so we'd like to cleaning up usages of deprecated API in third-party plugins. This PR makes sure that DatabaseAuthProvider implementations in AWS Toolkit are up-to-date
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.