Skip to content

fix(toolkit): fix incompatible version warning in toolkit #5986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 20, 2025
+8 −0
Merged

fix(toolkit): fix incompatible version warning in toolkit #5986

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b727ea
fix(toolkit): fix incompatible version warning in toolkit
manodnyab Aug 20, 2025
f7ca8b3
changelog
manodnyab Aug 20, 2025
f3cb13a
feedback
manodnyab Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .changes/next-release/bugfix-5f981bc5-69dd-4ecc-9b31-24f5d66b1948.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"type" : "bugfix",
"description" : "fix incompatible version warning for AWS Toolkit in 252"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description" : "fix incompatible version warning for AWS Toolkit in 252"
"description" : Fix incompatible version warning for AWS Toolkit in 2025.2"

}
1 change: 1 addition & 0 deletions plugins/toolkit/intellij-standalone/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ intellijPlatform {
dependencies {
intellijPlatform {
localPlugin(project(":plugin-core"))
plugin("PythonCore:243.18137.10")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed

}
}

Expand Down
4 changes: 4 additions & 0 deletions plugins/toolkit/jetbrains-core/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ val patchPluginXml = tasks.named<PatchPluginXmlTask>("patchPluginXml")
patchPluginXml.configure {
val buildSuffix = if (!project.isCi()) "+${buildMetadata()}" else ""
pluginVersion.set("$toolkitVersion.${ideProfile.shortName}$buildSuffix")
sinceBuild.set(ideProfile.sinceVersion)
untilBuild.set(ideProfile.untilVersion)
}

tasks.jar {
Expand All @@ -79,6 +81,8 @@ tasks.integrationTest {
val gatewayPluginXml = tasks.register<PatchPluginXmlTask>("pluginXmlForGateway") {
val buildSuffix = if (!project.isCi()) "+${buildMetadata()}" else ""
pluginVersion.set("GW-$toolkitVersion-${ideProfile.shortName}$buildSuffix")
sinceBuild.set(ideProfile.sinceVersion)
untilBuild.set(ideProfile.untilVersion)
}

val patchGatewayPluginXml by tasks.registering {
Expand Down
Loading