perf: cleanup/reduce de/ser cycles introduced in #5970 #5992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rli
changed the title
Comment on lines
595
to
598
| data class FlareAggregatedFindings( | ||
| val messageId: String, | ||
| val body: List<AggregatedCodeScanIssue>, | ||
| ) |
There was a problem hiding this comment.
Only findings messages have this format, others do not. I am worried if we force this typing, it will cause errors
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
manodnyab
approved these changes
Aug 26, 2025
XiaoxuanLu
approved these changes
Aug 27, 2025
6 tasks
rli
pushed a commit
that referenced
this pull request
Sep 11, 2025
When this cleanup PR got merged: #5992 There was some mishandling of the message, causing issues to not be populated in the CodeIssues Panel and causing the findings json to be sent to the chat.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the amount of Gson calls added by #5970
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.