-
Notifications
You must be signed in to change notification settings - Fork 273
merge: support chat on remote connections #6008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anes on local or remote (#5463) * Fixing bugs IDE-16164 and IDE-16163
This reverts commit a5e07dd.
…#5489) https://developer.mozilla.org/en-US/docs/Web/API/Clipboard `navigator.clipboard` is only accessible from a "secure context", which JCEF does not think we are using, because the URI authority is not localhost or https. Since we are hooking onto the CEF resource request handler, it does not matter what we use for the scheme/authority as long as there is no conflict with real resources. Previous implementation used a different load mechanism which somehow met the secure context criteria.
Merge main into feature/remote-chat-lsp
on remote, it can take 10+ seconds for chat to be visible. additionally, delete some unneeded assets to slightly reduce load time
Per internal discussion, feature deemed not ready for external users due to https://youtrack.jetbrains.com/issue/IJPL-203169
manodnyab
approved these changes
Aug 29, 2025
Qodana Community for JVM13 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
...oftware/aws/toolkits/jetbrains/services/amazonqCodeTest/controller/CodeTestChatController.kt
Fixed
Show fixed
Hide fixed
...oftware/aws/toolkits/jetbrains/services/amazonqFeatureDev/controller/FeatureDevController.kt
Fixed
Show fixed
Hide fixed
...ains-community/src/software/aws/toolkits/jetbrains/services/cwc/controller/ChatController.kt
Fixed
Show fixed
Hide fixed
...src/software/aws/toolkits/jetbrains/services/cwc/editor/context/file/FileContextExtractor.kt
Fixed
Show fixed
Hide fixed
...re/aws/toolkits/jetbrains/services/cwc/editor/context/focusArea/FocusAreaContextExtractor.kt
Fixed
Show fixed
Hide fixed
...shared/jetbrains-community/src/software/aws/toolkits/jetbrains/DefaultProblemsViewMutator.kt
Fixed
Show fixed
Hide fixed
...rains-community/src/contrib/org/intellij/images/editor/impl/jcef/JBCefLocalRequestHandler.kt
Fixed
Show fixed
Hide fixed
...rains-community/src/contrib/org/intellij/images/editor/impl/jcef/JBCefLocalRequestHandler.kt
Fixed
Show fixed
Hide fixed
...-community/src/software/aws/toolkits/jetbrains/core/webview/LocalAssetJBCefRequestHandler.kt
Fixed
Show fixed
Hide fixed
...-community/src/software/aws/toolkits/jetbrains/core/webview/LocalAssetJBCefRequestHandler.kt
Fixed
Show fixed
Hide fixed
XiaoxuanLu
approved these changes
Sep 3, 2025
shruti0085
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.