Skip to content

Commit 12135f0

Browse files
committed
address comment to imporve error msg lists
1 parent b6997c0 commit 12135f0

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{
2+
"type": "Bug Fix",
3+
"description": "filter out frequent client error from codegeneration telemetry"
4+
}

packages/core/src/amazonqFeatureDev/controllers/chat/controller.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -562,18 +562,17 @@ export class FeatureDevController {
562562
result = MetricDataResult.Error
563563
break
564564
default:
565-
const clinetErrorMessages = [
566-
'Improperly formed request',
567-
'Resource not found',
565+
const startCodeGenClientError = ['Improperly formed request', 'Resource not found']
566+
const clientErrorMessages = [
568567
'StartTaskAssistCodeGeneration reached for this month.',
569568
'The folder you chose did not contain any source files in a supported language. Choose another folder and try again.',
570569
'reached the quota for number of iterations on code generation.',
571570
]
572571

573572
if (
574573
(err.code === 'StartCodeGenerationFailed' &&
575-
clinetErrorMessages.slice(0, 2).some((msg) => err.message.includes(msg))) ||
576-
clinetErrorMessages.slice(2).some((msg) => err.message.includes(msg))
574+
startCodeGenClientError.some((msg) => err.message.includes(msg))) ||
575+
clientErrorMessages.some((msg) => err.message.includes(msg))
577576
) {
578577
result = MetricDataResult.Error
579578
} else {

0 commit comments

Comments
 (0)