Skip to content

Commit 17588bc

Browse files
authored
CI: Add test matrix to GitHub actions workflows (#1482)
- Run min/stable/insiders for mac - Run stable/insiders for Windows. Min is broken, it segfaults on GitHub actions
1 parent 6dfa4c3 commit 17588bc

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

.github/workflows/node.js.yml

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,10 @@ jobs:
1616
strategy:
1717
matrix:
1818
node-version: [12.x]
19+
vscode-version: [minimum, stable, insiders]
20+
env:
21+
VSCODE_TEST_VERSION: ${{ matrix.vscode-version }}
22+
NODE_OPTIONS: '--max-old-space-size=8192'
1923
steps:
2024
- uses: actions/checkout@v2
2125
- name: Use Node.js ${{ matrix.node-version }}
@@ -24,8 +28,6 @@ jobs:
2428
node-version: ${{ matrix.node-version }}
2529
- run: npm install
2630
- run: npm run vscode:prepublish
27-
env:
28-
NODE_OPTIONS: '--max-old-space-size=8192'
2931
- name: Tests
3032
uses: GabrielBB/xvfb-action@v1
3133
with:
@@ -40,6 +42,10 @@ jobs:
4042
strategy:
4143
matrix:
4244
node-version: [12.x]
45+
vscode-version: [stable, insiders]
46+
env:
47+
NODE_OPTIONS: '--max-old-space-size=8192'
48+
VSCODE_TEST_VERSION: ${{ matrix.vscode-version }}
4349
steps:
4450
- uses: actions/checkout@v2
4551
- name: Use Node.js ${{ matrix.node-version }}
@@ -48,7 +54,6 @@ jobs:
4854
node-version: ${{ matrix.node-version }}
4955
- run: npm install
5056
- run: npm run vscode:prepublish
51-
env:
52-
NODE_OPTIONS: '--max-old-space-size=8192'
5357
- name: Tests
5458
run: npm test
59+

0 commit comments

Comments
 (0)