Skip to content

Commit 2215460

Browse files
JadenSimonJadenSimon
authored
fix(auth): adjust UI on C9 #2994
Problem: * Missing icons * Tree nodes don't refresh in all cases * Tree nodes do not render `description` * Auth node gets sorted to the bottom which looks bad Solution: * Update `generateIcons.ts` to dump `@vscode/codicons` * All codicons retrieved with `getIcon` will now work with anything that uses `iconPath` * Refresh on more things when in C9 * Omit dev tools auth node in C9 * Add `description` to tree node tooltip
1 parent 357517b commit 2215460

25 files changed

+135
-89
lines changed

‎package-lock.json‎

Lines changed: 9 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json‎

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -3153,126 +3153,126 @@
31533153
"description": "AWS Contributed Icon",
31543154
"default": {
31553155
"fontPath": "./resources/fonts/aws-toolkit-icons.woff",
3156-
"fontCharacter": "\\e000"
3156+
"fontCharacter": "\\e1a5"
31573157
}
31583158
},
31593159
"aws-cdk-logo": {
31603160
"description": "AWS Contributed Icon",
31613161
"default": {
31623162
"fontPath": "./resources/fonts/aws-toolkit-icons.woff",
3163-
"fontCharacter": "\\e001"
3163+
"fontCharacter": "\\e1a6"
31643164
}
31653165
},
31663166
"aws-cloudformation-stack": {
31673167
"description": "AWS Contributed Icon",
31683168
"default": {
31693169
"fontPath": "./resources/fonts/aws-toolkit-icons.woff",
3170-
"fontCharacter": "\\e002"
3170+
"fontCharacter": "\\e1a7"
31713171
}
31723172
},
31733173
"aws-cloudwatch-log-group": {
31743174
"description": "AWS Contributed Icon",
31753175
"default": {
31763176
"fontPath": "./resources/fonts/aws-toolkit-icons.woff",
3177-
"fontCharacter": "\\e003"
3177+
"fontCharacter": "\\e1a8"
31783178
}
31793179
},
31803180
"aws-ecr-registry": {
31813181
"description": "AWS Contributed Icon",
31823182
"default": {
31833183
"fontPath": "./resources/fonts/aws-toolkit-icons.woff",
3184-
"fontCharacter": "\\e004"
3184+
"fontCharacter": "\\e1a9"
31853185
}
31863186
},
31873187
"aws-ecs-cluster": {
31883188
"description": "AWS Contributed Icon",
31893189
"default": {
31903190
"fontPath": "./resources/fonts/aws-toolkit-icons.woff",
3191-
"fontCharacter": "\\e005"
3191+
"fontCharacter": "\\e1aa"
31923192
}
31933193
},
31943194
"aws-ecs-container": {
31953195
"description": "AWS Contributed Icon",
31963196
"default": {
31973197
"fontPath": "./resources/fonts/aws-toolkit-icons.woff",
3198-
"fontCharacter": "\\e006"
3198+
"fontCharacter": "\\e1ab"
31993199
}
32003200
},
32013201
"aws-ecs-service": {
32023202
"description": "AWS Contributed Icon",
32033203
"default": {
32043204
"fontPath": "./resources/fonts/aws-toolkit-icons.woff",
3205-
"fontCharacter": "\\e007"
3205+
"fontCharacter": "\\e1ac"
32063206
}
32073207
},
32083208
"aws-generic-attach-file": {
32093209
"description": "AWS Contributed Icon",
32103210
"default": {
32113211
"fontPath": "./resources/fonts/aws-toolkit-icons.woff",
3212-
"fontCharacter": "\\e008"
3212+
"fontCharacter": "\\e1ad"
32133213
}
32143214
},
32153215
"aws-iot-certificate": {
32163216
"description": "AWS Contributed Icon",
32173217
"default": {
32183218
"fontPath": "./resources/fonts/aws-toolkit-icons.woff",
3219-
"fontCharacter": "\\e009"
3219+
"fontCharacter": "\\e1ae"
32203220
}
32213221
},
32223222
"aws-iot-policy": {
32233223
"description": "AWS Contributed Icon",
32243224
"default": {
32253225
"fontPath": "./resources/fonts/aws-toolkit-icons.woff",
3226-
"fontCharacter": "\\e00a"
3226+
"fontCharacter": "\\e1af"
32273227
}
32283228
},
32293229
"aws-iot-thing": {
32303230
"description": "AWS Contributed Icon",
32313231
"default": {
32323232
"fontPath": "./resources/fonts/aws-toolkit-icons.woff",
3233-
"fontCharacter": "\\e00b"
3233+
"fontCharacter": "\\e1b0"
32343234
}
32353235
},
32363236
"aws-lambda-function": {
32373237
"description": "AWS Contributed Icon",
32383238
"default": {
32393239
"fontPath": "./resources/fonts/aws-toolkit-icons.woff",
3240-
"fontCharacter": "\\e00c"
3240+
"fontCharacter": "\\e1b1"
32413241
}
32423242
},
32433243
"aws-s3-bucket": {
32443244
"description": "AWS Contributed Icon",
32453245
"default": {
32463246
"fontPath": "./resources/fonts/aws-toolkit-icons.woff",
3247-
"fontCharacter": "\\e00d"
3247+
"fontCharacter": "\\e1b2"
32483248
}
32493249
},
32503250
"aws-s3-create-bucket": {
32513251
"description": "AWS Contributed Icon",
32523252
"default": {
32533253
"fontPath": "./resources/fonts/aws-toolkit-icons.woff",
3254-
"fontCharacter": "\\e00e"
3254+
"fontCharacter": "\\e1b3"
32553255
}
32563256
},
32573257
"aws-schemas-registry": {
32583258
"description": "AWS Contributed Icon",
32593259
"default": {
32603260
"fontPath": "./resources/fonts/aws-toolkit-icons.woff",
3261-
"fontCharacter": "\\e00f"
3261+
"fontCharacter": "\\e1b4"
32623262
}
32633263
},
32643264
"aws-schemas-schema": {
32653265
"description": "AWS Contributed Icon",
32663266
"default": {
32673267
"fontPath": "./resources/fonts/aws-toolkit-icons.woff",
3268-
"fontCharacter": "\\e010"
3268+
"fontCharacter": "\\e1b5"
32693269
}
32703270
},
32713271
"aws-stepfunctions-preview": {
32723272
"description": "AWS Contributed Icon",
32733273
"default": {
32743274
"fontPath": "./resources/fonts/aws-toolkit-icons.woff",
3275-
"fontCharacter": "\\e011"
3275+
"fontCharacter": "\\e1b6"
32763276
}
32773277
}
32783278
}
@@ -3332,6 +3332,7 @@
33323332
"@types/xml2js": "^0.4.8",
33333333
"@typescript-eslint/eslint-plugin": "^5.38.0",
33343334
"@typescript-eslint/parser": "^5.38.0",
3335+
"@vscode/codicons": "^0.0.32",
33353336
"@vscode/test-electron": "^2.1.5",
33363337
"@vue/compiler-sfc": "^3.2.40",
33373338
"circular-dependency-plugin": "^5.2.2",
@@ -3373,7 +3374,6 @@
33733374
"@aws-sdk/credential-provider-process": "^3.15.0",
33743375
"@aws-sdk/credential-provider-sso": "^3.38.0",
33753376
"@aws-sdk/util-arn-parser": "^3.46.0",
3376-
"@vscode/codicons": "^0.0.29",
33773377
"adm-zip": "^0.5.9",
33783378
"amazon-states-language-service": "^1.7.2",
33793379
"async-lock": "^1.3.0",

‎package.nls.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@
185185
"AWS.generic.preview": "Preview",
186186
"AWS.generic.viewDocs": "View Documentation",
187187
"AWS.ssmDocument.ssm.maxItemsComputed.desc": "Controls the maximum number of problems produced by the SSM Document language server.",
188-
"AWS.walkthrough.gettingStarted.title": "Get Started with AWS",
188+
"AWS.walkthrough.gettingStarted.title": "Get started with AWS",
189189
"AWS.walkthrough.gettingStarted.description": "These walkthroughs help you set up the AWS Toolkit.",
190190
"AWS.walkthrough.gettingStarted.description.cn": "These walkthroughs help you set up the Amazon Toolkit.",
191191
"AWS.walkthrough.gettingStarted.connect": "Connect to AWS",

‎resources/icons/vscode/codicons/add.svg‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎resources/icons/vscode/codicons/chevron-up.svg‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎resources/icons/vscode/codicons/close.svg‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎resources/icons/vscode/codicons/debug-pause.svg‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎resources/icons/vscode/codicons/debug-start.svg‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎resources/icons/vscode/codicons/edit.svg‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎resources/icons/vscode/codicons/file.svg‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)