refactor error msgs to constants

Author: linyuxi-0511

packages/core/src/amazonqFeatureDev/constants.ts

@@ -20,6 +20,12 @@ export const generateDevFilePrompt =
 // Max allowed size for file collection
 export const maxRepoSizeBytes = 200 * 1024 * 1024
 
+export const startCodeGenClientErrorMessages = ['Improperly formed request', 'Resource not found']
+export const clientErrorMessages = [
+    'StartTaskAssistCodeGeneration reached for this month.',
+    'The folder you chose did not contain any source files in a supported language. Choose another folder and try again.',
+]
+
 // License text that's used in codewhisperer reference log
 export const referenceLogText = (reference: CodeReference) =>
     `[${new Date().toLocaleString()}] Accepted recommendation from Amazon Q. Code provided with reference under <a href="${LicenseUtil.getLicenseHtml(

packages/core/src/amazonqFeatureDev/controllers/chat/controller.ts

@@ -29,7 +29,13 @@ import {
 } from '../../errors'
 import { codeGenRetryLimit, defaultRetryLimit } from '../../limits'
 import { Session } from '../../session/session'
-import { featureDevScheme, featureName, generateDevFilePrompt } from '../../constants'
+import {
+    clientErrorMessages,
+    featureDevScheme,
+    featureName,
+    generateDevFilePrompt,
+    startCodeGenClientErrorMessages,
+} from '../../constants'
 import { DeletedFileInfo, DevPhase, MetricDataOperationName, MetricDataResult, type NewFileInfo } from '../../types'
 import { AuthUtil } from '../../../codewhisperer/util/authUtil'
 import { AuthController } from '../../../amazonq/auth/controller'
@@ -562,16 +568,9 @@ export class FeatureDevController {
                     result = MetricDataResult.Error
                     break
                 default:
-                    const startCodeGenClientError = ['Improperly formed request', 'Resource not found']
-                    const clientErrorMessages = [
-                        'StartTaskAssistCodeGeneration reached for this month.',
-                        'The folder you chose did not contain any source files in a supported language. Choose another folder and try again.',
-                        'reached the quota for number of iterations on code generation.',
-                    ]
-
                     if (
                         (err.code === 'StartCodeGenerationFailed' &&
-                            startCodeGenClientError.some((msg) => err.message.includes(msg))) ||
+                            startCodeGenClientErrorMessages.some((msg) => err.message.includes(msg))) ||
                         clientErrorMessages.some((msg) => err.message.includes(msg))
                     ) {
                         result = MetricDataResult.Error