Skip to content

Commit 52c53e3

Browse files
committed
List all CFN resources that are not DELETE_COMPLETE
1 parent 17588bc commit 52c53e3

File tree

3 files changed

+28
-7
lines changed

3 files changed

+28
-7
lines changed

src/shared/clients/cloudFormationClient.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ export interface CloudFormationClient {
1010

1111
deleteStack(name: string): Promise<void>
1212

13-
listStacks(statusFilter?: string[]): AsyncIterableIterator<CloudFormation.StackSummary>
13+
listStacks(): AsyncIterableIterator<CloudFormation.StackSummary>
1414

1515
describeStackResources(name: string): Promise<CloudFormation.DescribeStackResourcesOutput>
1616
}

src/shared/clients/defaultCloudFormationClient.ts

Lines changed: 25 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,34 @@ export class DefaultCloudFormationClient implements CloudFormationClient {
2121
.promise()
2222
}
2323

24-
public async *listStacks(
25-
statusFilter: string[] = ['CREATE_COMPLETE', 'UPDATE_COMPLETE']
26-
): AsyncIterableIterator<CloudFormation.StackSummary> {
24+
public async *listStacks(): AsyncIterableIterator<CloudFormation.StackSummary> {
2725
const client = await this.createSdkClient()
2826

2927
const request: CloudFormation.ListStacksInput = {
30-
StackStatusFilter: statusFilter,
28+
// Every StackStatus except for DELETE_COMPLETE
29+
StackStatusFilter: [
30+
'CREATE_IN_PROGRESS',
31+
'CREATE_FAILED',
32+
'CREATE_COMPLETE',
33+
'ROLLBACK_IN_PROGRESS',
34+
'ROLLBACK_FAILED',
35+
'ROLLBACK_COMPLETE',
36+
'DELETE_IN_PROGRESS',
37+
'DELETE_FAILED',
38+
'UPDATE_IN_PROGRESS',
39+
'UPDATE_COMPLETE_CLEANUP_IN_PROGRESS',
40+
'UPDATE_COMPLETE',
41+
'UPDATE_ROLLBACK_IN_PROGRESS',
42+
'UPDATE_ROLLBACK_FAILED',
43+
'UPDATE_ROLLBACK_COMPLETE_CLEANUP_IN_PROGRESS',
44+
'UPDATE_ROLLBACK_COMPLETE',
45+
'REVIEW_IN_PROGRESS',
46+
'IMPORT_IN_PROGRESS',
47+
'IMPORT_COMPLETE',
48+
'IMPORT_ROLLBACK_IN_PROGRESS',
49+
'IMPORT_ROLLBACK_FAILED',
50+
'IMPORT_ROLLBACK_COMPLETE',
51+
],
3152
}
3253

3354
do {

src/test/shared/clients/mockClients.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -154,9 +154,9 @@ export class MockCloudFormationClient implements CloudFormationClient {
154154

155155
public readonly deleteStack: (name: string) => Promise<void> = async (name: string) => {},
156156

157-
public readonly listStacks: (statusFilter?: string[]) => AsyncIterableIterator<CloudFormation.StackSummary> = (
157+
public readonly listStacks: (
158158
statusFilter?: string[]
159-
) => asyncGenerator([]),
159+
) => AsyncIterableIterator<CloudFormation.StackSummary> = () => asyncGenerator([]),
160160

161161
public readonly describeStackResources: (
162162
name: string

0 commit comments

Comments
 (0)