Skip to content

Commit 7883fea

Browse files
authored
feat(dev): autofill login starturl setting (#4918)
New dev setting to autofill the start url: ``` "aws.dev.autofillStartUrl": "<url>" ``` Should probably be integrated into the login page for all users somehow, but that requires some UX thought. Here is a quick fix for devs.
1 parent 83742b9 commit 7883fea

File tree

3 files changed

+10
-0
lines changed

3 files changed

+10
-0
lines changed

packages/core/src/login/webview/vue/backend.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ import { telemetry } from '../../../shared/telemetry'
3030
import { AuthSources } from '../util'
3131
import { AuthEnabledFeatures, AuthError, AuthFlowState, AuthUiClick, TelemetryMetadata, userCancelled } from './types'
3232
import { AuthUtil } from '../../../codewhisperer/util/authUtil'
33+
import { DevSettings } from '../../../shared/settings'
3334

3435
export abstract class CommonAuthWebview extends VueWebview {
3536
private metricMetadata: TelemetryMetadata = {}
@@ -291,4 +292,8 @@ export abstract class CommonAuthWebview extends VueWebview {
291292

292293
return authEnabledFeatures.join(',')
293294
}
295+
296+
getDefaultStartUrl() {
297+
return DevSettings.instance.get('autofillStartUrl', '')
298+
}
294299
}

packages/core/src/login/webview/vue/login.vue

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -330,6 +330,7 @@ export default defineComponent({
330330
}
331331
},
332332
async created() {
333+
this.startUrl = await this.getDefaultStartUrl()
333334
await this.emitUpdate('created')
334335
},
335336
@@ -500,6 +501,9 @@ export default defineComponent({
500501
501502
this.$forceUpdate()
502503
},
504+
async getDefaultStartUrl() {
505+
return await client.getDefaultStartUrl()
506+
},
503507
},
504508
})
505509
</script>

packages/core/src/shared/settings.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -729,6 +729,7 @@ const devSettings = {
729729
ssoCacheDirectory: String,
730730
enableIamPolicyChecksFeature: Boolean,
731731
pkceAuth: Boolean,
732+
autofillStartUrl: String,
732733
}
733734
type ResolvedDevSettings = FromDescriptor<typeof devSettings>
734735
type AwsDevSetting = keyof ResolvedDevSettings

0 commit comments

Comments
 (0)