perf: do not watch files in node_modules #3440

Problem:
When setting up file watchers, Toolkit includes unwanted directories
such as "node_modules". The default vscode setting `search.exclude`
excludes "node_modules", but `vscode.workspace.findFiles()` uses the
`files.exclude` as its default exclude pattern. #3216

Solution:
Specify an exclude pattern that matches the defaults from both
`search.exclude` and `files.exclude`, plus some other things like
".aws-sam/". Do this for all `WatchedFiles` subclasses because there is
no case where we want to watch files in any of these folders.

BEFORE:

    2023-05-10 04:24:34 [VERBOSE]: cfn: template registry setup took 257ms

AFTER:

    2023-05-10 04:23:22 [VERBOSE]: cfn: template registry setup took 53ms

Author: justinmk3

src/shared/fs/templateRegistry.ts

@@ -17,6 +17,7 @@ import globals from '../extensionGlobals'
 import { isUntitledScheme, normalizeVSCodeUri } from '../utilities/vsCodeUtils'
 import { sleep } from '../utilities/timeoutUtils'
 import { localize } from '../utilities/vsCodeUtils'
+import { PerfLog } from '../logger/logger'
 
 export class CloudFormationTemplateRegistry extends WatchedFiles<CloudFormation.Template> {
     protected name: string = 'CloudFormationTemplateRegistry'
@@ -90,10 +91,10 @@ export class AsyncCloudFormationTemplateRegistry {
         private readonly instance: CloudFormationTemplateRegistry,
         asyncSetupFunc: (instance: CloudFormationTemplateRegistry) => Promise<void>
     ) {
-        getLogger().info('cfn: starting template registry setup.')
+        const perflog = new PerfLog('cfn: template registry setup')
         asyncSetupFunc(instance).then(() => {
             this.isSetup = true
-            getLogger().info('cfn: template registry setup successful.')
+            perflog.done()
         })
     }
 
@@ -120,11 +121,11 @@ export class AsyncCloudFormationTemplateRegistry {
                         // Allows for new message to be created if templateRegistry variable attempted to be used again
                         this.setupProgressMessage = undefined
                     })
-                    getLogger().info('cfn: Waiting for template registry setup to complete.')
+                    getLogger().debug('cfn: getInstance() requested, still initializing')
                     while (!this.isSetup) {
                         await sleep(2000)
                     }
-                    getLogger().info('cfn: Finished waiting for template registry setup.')
+                    getLogger().debug('cfn: getInstance() ready')
                 }
             )
         }

src/shared/fs/watchedFiles.ts

@@ -9,6 +9,13 @@ import * as pathutils from '../utilities/pathUtils'
 import * as path from 'path'
 import { isUntitledScheme, normalizeVSCodeUri } from '../utilities/vsCodeUtils'
 
+/**
+ * Prevent `findFiles()` from recursing into these directories.
+ *
+ * `findFiles()` defaults to the vscode `files.exclude` setting, which by default does not exclude "node_modules/".
+ */
+const alwaysExclude = '**/{.aws-sam,.git,.svn,.hg,.rvm,.gem,.project,node_modules,venv,bower_components}/'
+
 export interface WatchedItem<T> {
     /**
      * The absolute path to the file
@@ -224,7 +231,7 @@ export abstract class WatchedFiles<T> implements vscode.Disposable {
     public async rebuild(): Promise<void> {
         this.reset()
         for (const glob of this.globs) {
-            const itemUris = await vscode.workspace.findFiles(glob)
+            const itemUris = await vscode.workspace.findFiles(glob, alwaysExclude)
             for (const item of itemUris) {
                 await this.addItemToRegistry(item, true)
             }